Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Segment Replication - Block snapshot creation if the target primary shard has not completed failover. #9721

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 731e043 from #9629.

…hard has not completed failover. (#9629)

* Segment Replication - Block snapshot creation if the target primary shard has not completed failover.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add unit test and remove non deterministic IT.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* spotless

Signed-off-by: Marc Handalian <handalm@amazon.com>

---------

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 731e043)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Compatibility status:

Checks if related components are compatible with change 5c03166

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #9721 (5c03166) into 2.x (58ae69d) will increase coverage by 0.00%.
Report is 3 commits behind head on 2.x.
The diff coverage is 73.83%.

@@            Coverage Diff            @@
##                2.x    #9721   +/-   ##
=========================================
  Coverage     70.80%   70.81%           
- Complexity    57868    57905   +37     
=========================================
  Files          4793     4794    +1     
  Lines        273397   273471   +74     
  Branches      40216    40227   +11     
=========================================
+ Hits         193583   193654   +71     
- Misses        63235    63277   +42     
+ Partials      16579    16540   -39     
Files Changed Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 93.18% <ø> (ø)
...st/action/cat/RestCatSegmentReplicationAction.java 25.74% <0.00%> (-19.81%) ⬇️
...opensearch/index/SegmentReplicationShardStats.java 30.43% <40.00%> (-8.59%) ⬇️
...replication/common/SegmentReplicationLagTimer.java 40.00% <40.00%> (ø)
.../indices/replication/SegmentReplicationTarget.java 84.87% <68.18%> (-4.13%) ⬇️
...earch/index/SegmentReplicationPressureService.java 76.69% <69.23%> (-0.63%) ⬇️
.../replication/checkpoint/ReplicationCheckpoint.java 84.61% <72.72%> (-3.11%) ⬇️
...org/opensearch/index/seqno/ReplicationTracker.java 68.57% <84.61%> (+0.11%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 68.92% <100.00%> (+0.26%) ⬆️
...x/store/remote/metadata/RemoteSegmentMetadata.java 100.00% <100.00%> (ø)
... and 2 more

... and 450 files with indirect coverage changes

@dreamer-89 dreamer-89 merged commit 42b30de into 2.x Sep 4, 2023
14 of 39 checks passed
@github-actions github-actions bot deleted the backport/backport-9629-to-2.x branch September 4, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant