Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Close Zstd Dictionary after execution to avoid any memory leak. (#9403) #9424

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

andrross
Copy link
Member

Backports 5cc7313 to 2.x

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change d555d1d

Incompatible components

Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.classMethod
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testScrollWithConcurrentIndexAndSearch
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation
      1 org.opensearch.index.translog.RemoteFSTranslogTests.testConcurrentWriteViewsAndSnapshot

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #9424 (97a5b9c) into 2.x (4cb5e66) will increase coverage by 0.07%.
Report is 4 commits behind head on 2.x.
The diff coverage is 70.83%.

@@             Coverage Diff              @@
##                2.x    #9424      +/-   ##
============================================
+ Coverage     70.82%   70.90%   +0.07%     
- Complexity    57570    57628      +58     
============================================
  Files          4762     4762              
  Lines        272058   272060       +2     
  Branches      40110    40110              
============================================
+ Hits         192681   192894     +213     
+ Misses        62900    62623     -277     
- Partials      16477    16543      +66     
Files Changed Coverage Δ
.../index/codec/customcodecs/ZstdCompressionMode.java 86.66% <70.83%> (+0.30%) ⬆️

... and 447 files with indirect coverage changes

…search-project#9403)

* Close Dictionary after every execution to avoid any memory leak

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>

* Close Dictionary after every execution to avoid any memory leak

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>

* Add changelog

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>

---------

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
(cherry picked from commit 5cc7313)
Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross andrross force-pushed the backport/backport-9403-to-2.x branch from 18d3f5a to 97a5b9c Compare August 18, 2023 18:50
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change b68d6ff

Incompatible components

Incompatible components: [https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testRequestStats

@reta reta merged commit c7fcd71 into opensearch-project:2.x Aug 18, 2023
11 checks passed
@andrross andrross deleted the backport/backport-9403-to-2.x branch August 18, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants