Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Rename RemoteRefreshSegmentPressureSettings and RemoteRefreshSegmentPressureService #9387

Conversation

BhumikaSaini-Amazon
Copy link
Contributor

Description

Backport #9253 to 2.x

Related Issues

#8311

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@BhumikaSaini-Amazon BhumikaSaini-Amazon changed the base branch from main to 2.x August 16, 2023 09:55
@BhumikaSaini-Amazon
Copy link
Contributor Author

This PR should be merged to 2.x after #9301 is merged to 2.x

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 5a25350

Incompatible components

Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

…RefreshSegmentPressureService (opensearch-project#9253)

---------

Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change a1dc776

Incompatible components

Incompatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchTimeoutIT.testSimpleTimeout {p0={"search.concurrent_segment_search.enabled":"true"}}

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #9387 (6f2d665) into 2.x (a1dc776) will decrease coverage by 0.05%.
The diff coverage is 32.25%.

@@             Coverage Diff              @@
##                2.x    #9387      +/-   ##
============================================
- Coverage     70.81%   70.77%   -0.05%     
+ Complexity    57569    57558      -11     
============================================
  Files          4762     4762              
  Lines        271983   272023      +40     
  Branches      40093    40104      +11     
============================================
- Hits         192610   192512      -98     
- Misses        62880    62975      +95     
- Partials      16493    16536      +43     
Files Changed Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 93.18% <ø> (ø)
...c/main/java/org/opensearch/index/IndexService.java 74.33% <ø> (-0.67%) ⬇️
...arch/index/remote/RemoteStorePressureSettings.java 94.44% <ø> (ø)
...in/java/org/opensearch/indices/IndicesService.java 70.75% <ø> (+0.30%) ⬆️
...rch/index/remote/RemoteSegmentTransferTracker.java 80.54% <3.70%> (-9.03%) ⬇️
...arch/index/store/DirectoryFileTransferTracker.java 82.43% <7.14%> (-17.57%) ⬇️
...ensearch/action/bulk/TransportShardBulkAction.java 75.87% <33.33%> (+1.37%) ⬆️
...testore/stats/TransportRemoteStoreStatsAction.java 44.44% <50.00%> (ø)
...in/cluster/remotestore/stats/RemoteStoreStats.java 93.67% <100.00%> (ø)
...earch/index/remote/RemoteStorePressureService.java 79.01% <100.00%> (ø)
... and 3 more

... and 431 files with indirect coverage changes

@sachinpkale sachinpkale merged commit 95b4f0b into opensearch-project:2.x Aug 16, 2023
12 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants