Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure test-retry plugin filter properly #8933

Merged

Conversation

andrross
Copy link
Member

The intent of #8825 was to retry only specified tests. The wrong parameter was configured though: 'filter' should be set, not 'classRetry'.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The intent of opensearch-project#8825 was to retry only specified tests. The wrong
parameter was configured though: ['filter' should be set][1], not
'classRetry'.

[1]: https://github.com/gradle/test-retry-gradle-plugin/blob/main/README.adoc#filtering

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/21158/

* **CommitID:** [c204c63](https://github.com/opensearch-project/OpenSearch/commit/c204c63ca38a8668bb4ae601bff574f62a3ab084)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

#8932

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testShardAlreadyReplicating

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #8933 (c204c63) into main (91bc891) will increase coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8933      +/-   ##
============================================
+ Coverage     71.05%   71.09%   +0.03%     
- Complexity    57198    57226      +28     
============================================
  Files          4758     4758              
  Lines        269863   269863              
  Branches      39484    39484              
============================================
+ Hits         191755   191848      +93     
+ Misses        61982    61842     -140     
- Partials      16126    16173      +47     

see 460 files with indirect coverage changes

@andrross andrross added the backport 2.x Backport to 2.x branch label Jul 27, 2023
@andrross andrross merged commit 5495c64 into opensearch-project:main Jul 27, 2023
@andrross andrross deleted the fix-test-filter-in-retry-plugin branch July 27, 2023 22:56
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 27, 2023
The intent of #8825 was to retry only specified tests. The wrong
parameter was configured though: ['filter' should be set][1], not
'classRetry'.

[1]: https://github.com/gradle/test-retry-gradle-plugin/blob/main/README.adoc#filtering

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 5495c64)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Jul 28, 2023
The intent of #8825 was to retry only specified tests. The wrong
parameter was configured though: ['filter' should be set][1], not
'classRetry'.

[1]: https://github.com/gradle/test-retry-gradle-plugin/blob/main/README.adoc#filtering


(cherry picked from commit 5495c64)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 28, 2023
The intent of opensearch-project#8825 was to retry only specified tests. The wrong
parameter was configured though: ['filter' should be set][1], not
'classRetry'.

[1]: https://github.com/gradle/test-retry-gradle-plugin/blob/main/README.adoc#filtering

Signed-off-by: Andrew Ross <andrross@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
The intent of opensearch-project#8825 was to retry only specified tests. The wrong
parameter was configured though: ['filter' should be set][1], not
'classRetry'.

[1]: https://github.com/gradle/test-retry-gradle-plugin/blob/main/README.adoc#filtering

Signed-off-by: Andrew Ross <andrross@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
The intent of opensearch-project#8825 was to retry only specified tests. The wrong
parameter was configured though: ['filter' should be set][1], not
'classRetry'.

[1]: https://github.com/gradle/test-retry-gradle-plugin/blob/main/README.adoc#filtering

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
The intent of opensearch-project#8825 was to retry only specified tests. The wrong
parameter was configured though: ['filter' should be set][1], not
'classRetry'.

[1]: https://github.com/gradle/test-retry-gradle-plugin/blob/main/README.adoc#filtering

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
The intent of opensearch-project#8825 was to retry only specified tests. The wrong
parameter was configured though: ['filter' should be set][1], not
'classRetry'.

[1]: https://github.com/gradle/test-retry-gradle-plugin/blob/main/README.adoc#filtering

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants