Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snapshot Interop] Keep API parameters behind remote store experiment… #8594

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

harishbhakuni
Copy link
Contributor

…al feature flag.

Description

Documentation Changes for Snapshot Interop Project are still not merged.
We will be launching Snapshot Interop Feature with Remote Store Feature, so as part of this PR we are keeping all the Snapshot Interop related API parameters behind the Remote Store Feature Flag.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Collaborator

gbbafna commented Jul 11, 2023

Do we really need these changes ? It might be okay showing some extra flags in API output as it wouldn't break the clients.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Collaborator

@sohami sohami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's create a tracking doc change for the new flag in create snapshot response.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…al flag.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gbbafna gbbafna merged commit c677f35 into opensearch-project:main Jul 11, 2023
@gbbafna
Copy link
Collaborator

gbbafna commented Jul 11, 2023

org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits

Failing tests are not related to this change and are flaky . Merging it as it is important to block interop related params when remote store is not enabled .

@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jul 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
…al flag. (#8594)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
(cherry picked from commit c677f35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Jul 11, 2023
…al flag. (#8594) (#8617)

(cherry picked from commit c677f35)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…al flag. (opensearch-project#8594)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…al flag. (opensearch-project#8594)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
…al flag. (opensearch-project#8594)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…al flag. (opensearch-project#8594)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…al flag. (opensearch-project#8594)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…al flag. (opensearch-project#8594)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants