Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Refactor] Refactors remaining ImmutableOpenMap usage to j.u.Map (#7309) #8316

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jun 28, 2023

Backport d984f50 from #7309.

@nknize nknize added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments labels Jun 28, 2023
@nknize nknize added the v2.9.0 'Issues and PRs related to version v2.9.0' label Jun 28, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator Author

nknize commented Jun 28, 2023

Okay, this is beyond ridiculous. These same BWC and Segrep w/ remote store tests keep failing. We need to either mute or fix them as the time loss has far surpassed unreasonable.

@nknize
Copy link
Collaborator Author

nknize commented Jun 28, 2023

I was able to periodically repro the Yaml test failures. Looks like there's an occasional java.net.ConnectException: Connection refused. Many of these instances occur from adminClient().performRequest(request); called from ensureNoInitializingShards(); I'm not sure this is specific to this call, though. Possibly we're running out of connections based on the cluster config?

Will keep digging.

…nsearch-project#7309)

Refactors all remaining usage of HPPC backed ImmutableOpenMap to
j.u.Map. This is the last usage of the class so ImmutableOpenMap is
completely removed in favor of java maps.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit d984f50)
@nknize nknize force-pushed the backport/backport-7309-to-2.x branch from 7aeebbf to 0ad7ad3 Compare June 30, 2023 15:05
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #8316 (0ad7ad3) into 2.x (04ec607) will decrease coverage by 0.02%.
The diff coverage is 91.48%.

@@             Coverage Diff              @@
##                2.x    #8316      +/-   ##
============================================
- Coverage     70.69%   70.68%   -0.02%     
- Complexity    56900    56901       +1     
============================================
  Files          4714     4713       -1     
  Lines        269657   269540     -117     
  Branches      39863    39856       -7     
============================================
- Hits         190640   190511     -129     
- Misses        62611    62684      +73     
+ Partials      16406    16345      -61     
Impacted Files Coverage Δ
...cluster/reroute/TransportClusterRerouteAction.java 44.73% <0.00%> (+0.58%) ⬆️
...ices/shards/TransportIndicesShardStoresAction.java 4.90% <0.00%> (ø)
...a/org/opensearch/common/io/stream/StreamInput.java 88.60% <ø> (-1.32%) ⬇️
.../org/opensearch/common/io/stream/StreamOutput.java 94.81% <ø> (-0.38%) ⬇️
.../src/main/java/org/opensearch/gateway/Gateway.java 8.33% <0.00%> (ø)
.../opensearch/rest/action/cat/RestIndicesAction.java 45.77% <0.00%> (-0.12%) ⬇️
...min/indices/shards/IndicesShardStoresResponse.java 53.19% <71.42%> (+1.41%) ⬆️
...dmin/indices/settings/get/GetSettingsResponse.java 74.39% <91.66%> (-0.61%) ⬇️
.../java/org/opensearch/index/mapper/FieldMapper.java 80.75% <94.11%> (+0.01%) ⬆️
...va/org/opensearch/cluster/node/DiscoveryNodes.java 87.62% <97.43%> (-1.60%) ⬇️
... and 18 more

... and 429 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments enhancement Enhancement or improvement to existing feature or request v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants