-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] remove unnecessary empty build.gradle
files
#8113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove unnecessary empty `build.gradle` files these have no impact, as the targets are added by the parent `build.gradle`. thus they do not need to exist and are currently just cluttering the workspace and confusing people trying to work in that area. see also the discussion on opensearch-build#99 for some details. Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> * Revert removal of distribution/docker/docker-export/build.gradle Signed-off-by: Kartik Ganesh <gkart@amazon.com> --------- Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> Signed-off-by: Kartik Ganesh <gkart@amazon.com> Co-authored-by: Kartik Ganesh <gkart@amazon.com> (cherry picked from commit a6b984b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
June 16, 2023 18:29
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #8113 +/- ##
============================================
+ Coverage 70.63% 70.69% +0.06%
- Complexity 56771 56897 +126
============================================
Files 4703 4703
Lines 269046 269056 +10
Branches 39768 39770 +2
============================================
+ Hits 190048 190220 +172
+ Misses 62694 62539 -155
+ Partials 16304 16297 -7
|
|
kartg
approved these changes
Jun 16, 2023
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
… (opensearch-project#8113) * remove unnecessary empty `build.gradle` files these have no impact, as the targets are added by the parent `build.gradle`. thus they do not need to exist and are currently just cluttering the workspace and confusing people trying to work in that area. see also the discussion on opensearch-build#99 for some details. * Revert removal of distribution/docker/docker-export/build.gradle --------- (cherry picked from commit a6b984b) Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> Signed-off-by: Kartik Ganesh <gkart@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kartik Ganesh <gkart@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a6b984b from #4723.