Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with delete shard routing weights on node restart #8057

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

imRishN
Copy link
Member

@imRishN imRishN commented Jun 14, 2023

Description

When a node is restarted after deleting the shard routing weights, the node fails to come up due to NPE encountered while reading WRR metadata. This PR fixes the bug

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #8057 (8daa8a5) into main (a81ef5a) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #8057      +/-   ##
============================================
- Coverage     70.92%   70.90%   -0.02%     
+ Complexity    56603    56571      -32     
============================================
  Files          4721     4721              
  Lines        267473   267473              
  Branches      39211    39211              
============================================
- Hits         189713   189661      -52     
- Misses        61767    61824      +57     
+ Partials      15993    15988       -5     
Impacted Files Coverage Δ
...rg/opensearch/cluster/routing/WeightedRouting.java 65.51% <0.00%> (ø)

... and 477 files with indirect coverage changes

@imRishN imRishN changed the title Fix bug with Delete shard routing weights on node restart Fix bug with delete shard routing weights on node restart Jun 14, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

@gbbafna gbbafna merged commit 87e34a3 into opensearch-project:main Jun 15, 2023
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jun 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 15, 2023
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
(cherry picked from commit 87e34a3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Jun 15, 2023
)

(cherry picked from commit 87e34a3)

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…-project#8057) (opensearch-project#8075)

(cherry picked from commit 87e34a3)

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
imRishN added a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…-project#8057)

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants