Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Reduce memory copy in zstd compression (#7681) #7865

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Jun 1, 2023

Backport of #7681 to 2.x

* 1. reduce memory copy in zstd compression

Signed-off-by: luyuncheng <luyuncheng@bytedance.com>

* Add Change log

Signed-off-by: luyuncheng <luyuncheng@bytedance.com>

---------

Signed-off-by: luyuncheng <luyuncheng@bytedance.com>
(cherry picked from commit a0a8a18)
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@luyuncheng
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #7865 (276f19c) into 2.x (f032091) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #7865      +/-   ##
============================================
+ Coverage     70.43%   70.56%   +0.13%     
- Complexity    56345    56418      +73     
============================================
  Files          4665     4665              
  Lines        267674   267674              
  Branches      39634    39634              
============================================
+ Hits         188531   188894     +363     
+ Misses        62837    62508     -329     
+ Partials      16306    16272      -34     
Impacted Files Coverage Δ
.../index/codec/customcodecs/ZstdCompressionMode.java 84.09% <100.00%> (ø)
.../codec/customcodecs/ZstdNoDictCompressionMode.java 76.71% <100.00%> (ø)

... and 469 files with indirect coverage changes

@dblock dblock merged commit 61348cc into opensearch-project:2.x Jun 1, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…nsearch-project#7865)

* 1. reduce memory copy in zstd compression

Signed-off-by: luyuncheng <luyuncheng@bytedance.com>

* Add Change log

Signed-off-by: luyuncheng <luyuncheng@bytedance.com>

---------

Signed-off-by: luyuncheng <luyuncheng@bytedance.com>
(cherry picked from commit a0a8a18)

Co-authored-by: luyuncheng <luyuncheng@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants