-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Concurrent Search Tasks Response Updates #7856
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Build failure due to |
b15e9f3
to
ab35d5d
Compare
Gradle Check (Jenkins) Run Completed with:
|
I can take a look at this test failure shortly. |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7856 +/- ##
============================================
- Coverage 70.58% 70.52% -0.07%
+ Complexity 56460 56433 -27
============================================
Files 4665 4666 +1
Lines 267675 267763 +88
Branches 39634 39651 +17
============================================
- Hits 188944 188844 -100
- Misses 62496 62617 +121
- Partials 16235 16302 +67
|
Looks like this is a mixed cluster with 1.3 and the problem is that |
rest-api-spec/src/main/resources/rest-api-spec/test/tasks.list/10_basic.yml
Outdated
Show resolved
Hide resolved
@reta should we just merge this PR as is and then I will open a new one with the test fix or is there a better way to handle this? |
@jed326 I will push the fix for tests tomorrow (sorry far from laptop), we should fix the tests right away before merging, moreover you find out the problem already, thank you. |
ab35d5d
to
1195448
Compare
* Add average,min,max and thread info to tasks response Signed-off-by: Jay Deng <jayd0104@gmail.com> * Update server/src/main/java/org/opensearch/tasks/TaskResourceStats.java Signed-off-by: Jay Deng <jayd0104@gmail.com> --------- Signed-off-by: Jay Deng <jayd0104@gmail.com> (cherry picked from commit e3740f7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
rest-api-spec/src/main/resources/rest-api-spec/test/tasks.list/10_basic.yml
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
1195448
to
f840f53
Compare
@jed326 looks good? we will bring version + tests changes to |
Gradle Check (Jenkins) Run Completed with:
|
@reta looks good to me. Thanks! |
@kotwanikunal may I ask you please to approve this backport? thank you |
…pensearch-project#7856) * Add average,min,max and thread info to tasks response * Update server/src/main/java/org/opensearch/tasks/TaskResourceStats.java --------- (cherry picked from commit e3740f7) Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Backport e3740f7 from #7673.