Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Mute testIndexingWithSegRep flaky test failure #7749

Merged
merged 1 commit into from
May 25, 2023

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented May 25, 2023

Description

This change mutes the recently introduces backward compatible tests for segment replication indices. The test currently fails for two different reasons:

  1. Targeted shard search request failures. This is posibly due to stale {index}/_stats results, where shard allocation is not correct.
org.opensearch.client.ResponseException: method [POST], host [http://127.0.0.1:35875], URI [/test-index-segrep/_search?rest_total_hits_as_int=true&filter_path=hits.total&preference=_shards%3A1%7C_only_nodes%3A8kJEQo6ASOaPpQE9rnJFRQ], status line [HTTP/1.1 400 Bad Request]
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"no data nodes with criteria [8kJEQo6ASOaPpQE9rnJFRQ] found for shard: [test-index-segrep][1]"}],"type":"illegal_argument_exception","reason":"no data nodes with criteria [8kJEQo6ASOaPpQE9rnJFRQ] found for shard: [test-index-segrep][1]"},"status":400}
  1. Index already exists exception. This is happens on retry of the test. Sample failure https://build.ci.opensearch.org/job/gradle-check/16262/testReport/
org.opensearch.client.ResponseException: method [PUT], host [http://127.0.0.1:44593/], URI [/test-index-segrep], status line [HTTP/1.1 400 Bad Request]
    {"error":{"root_cause":[{"type":"resource_already_exists_exception","reason":"index [test-index-segrep/-b5P3IJMS2mZGT60HKdIcQ] already exists","index":"test-index-segrep","index_uuid":"-b5P3IJMS2mZGT60HKdIcQ"}],"type":"resource_already_exists_exception","reason":"index [test-index-segrep/-b5P3IJMS2mZGT60HKdIcQ] already exists","index":"test-index-segrep","index_uuid":"-b5P3IJMS2mZGT60HKdIcQ"},"status":400}

Related Issues

Related: #7679

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #7749 (9b9a7c7) into main (70b109d) will increase coverage by 0.25%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7749      +/-   ##
============================================
+ Coverage     70.63%   70.89%   +0.25%     
- Complexity    56099    56264     +165     
============================================
  Files          4680     4680              
  Lines        266083   266083              
  Branches      39074    39074              
============================================
+ Hits         187955   188646     +691     
+ Misses        62187    61445     -742     
- Partials      15941    15992      +51     

see 486 files with indirect coverage changes

@kotwanikunal kotwanikunal merged commit 6a3f350 into opensearch-project:main May 25, 2023
suranjay pushed a commit to suranjay/OpenSearch that referenced this pull request May 29, 2023
Signed-off-by: Suraj Singh <surajrider@gmail.com>
stephen-crawford pushed a commit to stephen-crawford/OpenSearch that referenced this pull request May 31, 2023
Signed-off-by: Suraj Singh <surajrider@gmail.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Jun 2, 2023
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@mch2 mch2 added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Aug 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 11, 2023
Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit 6a3f350)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants