[Backport 2.x] Adding task cancellation timestamp in task API #7704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Adding task cancellation time in task API Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Fixing unit tests and addressing comments Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Adding change log for unreleased 2.x Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Removing running time cancel info from task API Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Replacing long primitive with Long object Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Making cancelledAt field human readable Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Fixing failing test Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Removing the feature from unreleased 3.x Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Fixing ListTasksResponseTests failure Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Test failure fix Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Changing naming convention to cancellationStartTime Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Co-authored-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 8d7a544) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
Gradle Check (Jenkins) Run Completed with:
|
|
@sgup432 Can you take a look at fixing up this backport? I think the bwc tests on main will break after merging this so we'll want to fix the version guards on main immediately after merging this backport. |
Sure, let me fix this. And then raise another fix on main. |
6 tasks
|
Please cancel this one. Raised a manual backport PR with 2.8 version change - #7711 |
|
Superceded by #7711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8d7a544 from #7445.