Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto plugin integration changes #7337

Conversation

vikasvb90
Copy link
Contributor

Description

This change is to integrate crypto plugin in remote store.

Related Issues

This is one of the tasks of meta issue #7229

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Gradle Check (Jenkins) Run Completed with:

@vikasvb90 vikasvb90 force-pushed the crypto_plugin_integration_with_remote_store branch from 227be42 to 6531662 Compare May 1, 2023 13:34
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Gradle Check (Jenkins) Run Completed with:

@vikasvb90 vikasvb90 force-pushed the crypto_plugin_integration_with_remote_store branch from 6531662 to 5aaacfd Compare May 2, 2023 03:22
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Gradle Check (Jenkins) Run Completed with:

@vikasvb90 vikasvb90 force-pushed the crypto_plugin_integration_with_remote_store branch from 5aaacfd to 8adb607 Compare May 2, 2023 03:57
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #7337 (8adb607) into main (6d9c82f) will decrease coverage by 0.11%.
The diff coverage is 78.44%.

❗ Current head 8adb607 differs from pull request most recent head e866f04. Consider uploading reports for the commit e866f04 to get more accurate results

@@             Coverage Diff              @@
##               main    #7337      +/-   ##
============================================
- Coverage     70.68%   70.58%   -0.11%     
- Complexity    56024    59522    +3498     
============================================
  Files          4673     4864     +191     
  Lines        265744   285623   +19879     
  Branches      39024    41162    +2138     
============================================
+ Hits         187832   201596   +13764     
- Misses        62020    67463    +5443     
- Partials      15892    16564     +672     
Impacted Files Coverage Δ
...ensearch/index/translog/transfer/FileSnapshot.java 63.88% <0.00%> (-1.83%) ⬇️
...g/opensearch/repositories/RepositoriesService.java 72.50% <0.00%> (+0.09%) ⬆️
...anslog/RemoteBlobStoreInternalTranslogFactory.java 66.66% <33.33%> (-10.26%) ⬇️
...search/index/shard/RemoteStoreRefreshListener.java 81.13% <42.85%> (-0.43%) ⬇️
...java/org/opensearch/index/shard/StoreRecovery.java 65.75% <50.00%> (-0.81%) ⬇️
...in/java/org/opensearch/index/shard/IndexShard.java 69.85% <53.33%> (-0.22%) ⬇️
...ndex/store/RemoteSegmentStoreDirectoryFactory.java 86.95% <77.77%> (-8.29%) ⬇️
...dex/translog/transfer/TranslogTransferManager.java 82.42% <85.71%> (-0.40%) ⬇️
...er/src/main/java/org/opensearch/common/Stream.java 87.50% <87.50%> (ø)
...ex/translog/transfer/BlobStoreTransferService.java 86.36% <87.50%> (-0.31%) ⬇️
... and 5 more

... and 888 files with indirect coverage changes

@vikasvb90 vikasvb90 force-pushed the crypto_plugin_integration_with_remote_store branch from 8adb607 to 4797a65 Compare May 19, 2023 10:42
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@vikasvb90 vikasvb90 force-pushed the crypto_plugin_integration_with_remote_store branch from 4797a65 to b04c070 Compare May 19, 2023 10:52
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@vikasvb90 vikasvb90 force-pushed the crypto_plugin_integration_with_remote_store branch from b04c070 to a02fd37 Compare May 19, 2023 11:18
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Vikas Bansal <vikasvb@amazon.com>
@vikasvb90 vikasvb90 force-pushed the crypto_plugin_integration_with_remote_store branch from a02fd37 to e866f04 Compare May 19, 2023 12:07
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jun 22, 2023
@vikasvb90 vikasvb90 removed the stalled Issues that have stalled label Jun 22, 2023
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jul 23, 2023
@vikasvb90 vikasvb90 added Storage:Durability Issues and PRs related to the durability framework v2.10.0 feature New feature or request and removed stalled Issues that have stalled labels Jul 24, 2023
@andrross
Copy link
Member

Closing this as it has been crossed out on the meta issue. @vikasvb90 Please reopen if this shouldn't be closed.

@andrross andrross closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request Storage:Durability Issues and PRs related to the durability framework v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants