Use lowercase letters for zstd, zstdnodict compression codecs. #7231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
mulugetam
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
6 tasks
reta
approved these changes
Apr 18, 2023
Gradle Check (Jenkins) Run Completed with:
|
Poojita-Raj
approved these changes
Apr 18, 2023
dblock
reviewed
Apr 19, 2023
| * lowercase letters when registering the codec so that we remain consistent with | ||
| * the other compression codecs: default, lucene_default, and best_compression. | ||
| * | ||
| * @param mode The compression codec (ZSTD or ZSTDNODICT). |
There was a problem hiding this comment.
Should be lowercase in the @param.
There was a problem hiding this comment.
The parameter is a Java enum.
| public Lucene95CustomCodec(Mode mode, int compressionLevel) { | ||
| super(mode.name(), new Lucene95Codec()); | ||
| super(mode.name().toLowerCase(Locale.ROOT), new Lucene95Codec()); |
There was a problem hiding this comment.
Why do we still want toLowerCase it here? If we want these to be case-sensitive we should get rid of anything that says ZSTD and replace it with zstd, no?
There was a problem hiding this comment.
I think this is to simplify a bit Mode conventions: since this is Java's enum, the convention is to use uppercased Java members (mode.name())
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com> (cherry picked from commit e791d46) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Apr 28, 2023
…earch-project#7231) Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…earch-project#7231) Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenSearch supports:
default,lucene_default,best_compression, andZSTDcompression codecs. This PR changesZSTDtozstdto maintain consistency in naming compression codecs.Issues Resolved
A follow up to PR: #7171.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.