Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fixing SortField comparison to use equals instead of reference equality #6957

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 55936ac from #6901.

…ty (#6901)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 55936ac)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.split/30_copy_settings/Copy settings during split index}

@codecov-commenter
Copy link

Codecov Report

Merging #6957 (6bf9ea8) into 2.x (5cf4c5d) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6957      +/-   ##
============================================
- Coverage     70.42%   70.29%   -0.13%     
+ Complexity    59500    59435      -65     
============================================
  Files          4811     4811              
  Lines        285539   285539              
  Branches      41509    41509              
============================================
- Hits         201086   200731     -355     
- Misses        67682    68037     +355     
  Partials      16771    16771              
Impacted Files Coverage Δ
...pensearch/action/search/SearchPhaseController.java 85.42% <100.00%> (+0.28%) ⬆️

... and 463 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dblock dblock merged commit 500108d into 2.x Apr 4, 2023
@github-actions github-actions bot deleted the backport/backport-6901-to-2.x branch April 4, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants