Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Segment Replication] Handling resource close #6804

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e58a33d from #6795.

* [Segment Replication] Fix resource close handling

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Fix unit tests and change exception type

Signed-off-by: Suraj Singh <surajrider@gmail.com>

---------

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit e58a33d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #6804 (3d34810) into 2.x (922ba68) will increase coverage by 0.09%.
The diff coverage is 54.54%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6804      +/-   ##
============================================
+ Coverage     70.35%   70.44%   +0.09%     
- Complexity    59363    59441      +78     
============================================
  Files          4806     4806              
  Lines        285283   285288       +5     
  Branches      41470    41473       +3     
============================================
+ Hits         200720   200984     +264     
+ Misses        67700    67515     -185     
+ Partials      16863    16789      -74     
Impacted Files Coverage Δ
...rg/opensearch/indices/recovery/RecoveryTarget.java 72.18% <ø> (-0.33%) ⬇️
...s/replication/SegmentReplicationTargetService.java 48.10% <0.00%> (ø)
.../indices/replication/SegmentReplicationTarget.java 90.26% <42.85%> (-3.20%) ⬇️
...uster/routing/allocation/DiskThresholdMonitor.java 71.48% <100.00%> (-4.58%) ⬇️
...ndices/replication/OngoingSegmentReplications.java 90.36% <100.00%> (ø)
.../indices/replication/common/ReplicationTarget.java 77.33% <100.00%> (ø)

... and 491 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dreamer-89 dreamer-89 merged commit 528cf87 into 2.x Mar 23, 2023
@github-actions github-actions bot deleted the backport/backport-6795-to-2.x branch March 23, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants