-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing input validation in segments and delete pit request #6645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharath-techie
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
March 13, 2023 04:22
bharath-techie
force-pushed
the
main
branch
2 times, most recently
from
March 13, 2023 04:27
44955ce
to
3d1b15a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #6645 +/- ##
============================================
+ Coverage 70.66% 70.68% +0.02%
- Complexity 56070 56143 +73
============================================
Files 4680 4680
Lines 266071 266073 +2
Branches 39072 39070 -2
============================================
+ Hits 188025 188086 +61
- Misses 62065 62072 +7
+ Partials 15981 15915 -66
|
Gradle Check (Jenkins) Run Completed with:
|
Arpit-Bandejiya
approved these changes
Mar 13, 2023
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
andrross
reviewed
May 24, 2023
...r/src/main/java/org/opensearch/action/admin/indices/segments/TransportPitSegmentsAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
andrross
approved these changes
May 24, 2023
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
approved these changes
May 25, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 25, 2023
* fixing input validation in segments and delete pit request Signed-off-by: Bharathwaj G <bharath78910@gmail.com> (cherry picked from commit c41c5c2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
May 25, 2023
…7754) * fixing input validation in segments and delete pit request (cherry picked from commit c41c5c2) Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
pushed a commit
to dblock/OpenSearch
that referenced
this pull request
May 25, 2023
…h-project#6645) * fixing input validation in segments and delete pit request Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
suranjay
pushed a commit
to suranjay/OpenSearch
that referenced
this pull request
May 29, 2023
…h-project#6645) * fixing input validation in segments and delete pit request Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
stephen-crawford
pushed a commit
to stephen-crawford/OpenSearch
that referenced
this pull request
May 31, 2023
…h-project#6645) * fixing input validation in segments and delete pit request Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Jun 2, 2023
…h-project#6645) * fixing input validation in segments and delete pit request Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…h-project#6645) * fixing input validation in segments and delete pit request Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before:
If same PIT ID is sent multiple times as part of delete list or pit segments list, then its processed multiple times.
After this change:
Only the unique PIT IDs are sent from rest layer to transport layer
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.