Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing input validation in segments and delete pit request #6645

Merged
merged 11 commits into from
May 25, 2023

Conversation

bharath-techie
Copy link
Contributor

Description

Before:
If same PIT ID is sent multiple times as part of delete list or pit segments list, then its processed multiple times.

After this change:
Only the unique PIT IDs are sent from rest layer to transport layer

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Merging #6645 (d49d0e5) into main (89edd55) will increase coverage by 0.02%.
The diff coverage is 81.81%.

@@             Coverage Diff              @@
##               main    #6645      +/-   ##
============================================
+ Coverage     70.66%   70.68%   +0.02%     
- Complexity    56070    56143      +73     
============================================
  Files          4680     4680              
  Lines        266071   266073       +2     
  Branches      39072    39070       -2     
============================================
+ Hits         188025   188086      +61     
- Misses        62065    62072       +7     
+ Partials      15981    15915      -66     
Impacted Files Coverage Δ
...pensearch/action/search/TransportSearchAction.java 70.99% <0.00%> (+0.43%) ⬆️
...n/indices/segments/TransportPitSegmentsAction.java 69.49% <66.66%> (ø)
...search/action/search/TransportDeletePitAction.java 100.00% <100.00%> (ø)
...nsearch/search/pipeline/SearchPipelineService.java 83.88% <100.00%> (+1.11%) ⬆️

... and 456 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
@andrross andrross added the backport 2.x Backport to 2.x branch label May 24, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@Bukhtawar Bukhtawar merged commit c41c5c2 into opensearch-project:main May 25, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 25, 2023
* fixing input validation in segments and delete pit request

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
(cherry picked from commit c41c5c2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request May 25, 2023
…7754)

* fixing input validation in segments and delete pit request


(cherry picked from commit c41c5c2)

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit to dblock/OpenSearch that referenced this pull request May 25, 2023
…h-project#6645)

* fixing input validation in segments and delete pit request

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
suranjay pushed a commit to suranjay/OpenSearch that referenced this pull request May 29, 2023
…h-project#6645)

* fixing input validation in segments and delete pit request

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
stephen-crawford pushed a commit to stephen-crawford/OpenSearch that referenced this pull request May 31, 2023
…h-project#6645)

* fixing input validation in segments and delete pit request

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Jun 2, 2023
…h-project#6645)

* fixing input validation in segments and delete pit request

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…h-project#6645)

* fixing input validation in segments and delete pit request

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants