-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Add new segrep settings #6523
[Segment Replication] Add new segrep settings #6523
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Gradle Check (Jenkins) Run Completed with:
|
@dreamer-89 After thinking on this more, do we really need new settings here? I think we may be able to simplify this by reusing the Recovery setting
|
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
cd7b940
to
08ce58b
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6523 +/- ##
============================================
+ Coverage 70.67% 70.74% +0.07%
- Complexity 59047 59058 +11
============================================
Files 4802 4802
Lines 282970 282973 +3
Branches 40793 40793
============================================
+ Hits 199982 200185 +203
+ Misses 66565 66340 -225
- Partials 16423 16448 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6523-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7b96c92522f6cb798e8f02b6a5ff796bb6078a70
# Push it to GitHub
git push --set-upstream origin backport/backport-6523-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
* [Segment Replication] Add segrep settings Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless fix Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
* [Segment Replication] Add segrep settings Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless fix Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
* [Segment Replication] Add segrep settings Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless fix Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Description
Updates
PrimaryShardReplicationSource
to use30mins
which is the segrep activity running time. It replaces existing hard-coded constant defining per minute bytes that can be processed by a host (default calculated for m5 machine). The other option is to expose this value as a dynmaic setting but then setting default is challenging and set the onus to end-user. For simplification, used max available timeout value for fetching the files.This change introduces two new settings for SegmentReplication inside RecoverySettings, keeping existing defaults.1. Use new dynamic setting for max bytes, source can process per minute. This is used in PrimaryShardReplicationSource to set the transport requst timeout for getting segment files from source. Using a setting is beneficial vs a hard-code constant as it alllows user to choose the right value based on hardware type.2. Use new dynamic segment replication activity timeout setting. When an replication activity is idle for this time period,ReplicationMonitor
removes the stale replication and fails the shard. The setting has existing default value of30mins
.Issues Resolved
#6027
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.