Fix inconsistent cluster state and ensure weigh away exception check only for data nodes #6327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is done only on data nodes Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
reviewed
Feb 15, 2023
| listener.onFailure(new NodeWeighedAwayException("local node is weighed away")); | ||
| return; | ||
| DiscoveryNode localNode = currentState.getNodes().getLocalNode(); | ||
| if (localNode.isDataNode()) { |
There was a problem hiding this comment.
Should it be made more generic based on roles?
There was a problem hiding this comment.
we can do that but can we say that all data nodes have DATA_ROLE? And warm nodes don't have DATA_ROLE
There was a problem hiding this comment.
added a todo to take this later
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
anshu1106
requested review from
reta,
anasalkouz,
andrross,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
anshu1106
force-pushed
the
cluster-health-state-fix
branch
from
dc1981d
to
3e6d718
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6327 +/- ##
============================================
+ Coverage 70.68% 70.75% +0.06%
- Complexity 58994 59018 +24
============================================
Files 4800 4800
Lines 282427 282430 +3
Branches 40717 40719 +2
============================================
+ Hits 199641 199822 +181
+ Misses 66378 66171 -207
- Partials 16408 16437 +29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gbbafna
reviewed
Feb 16, 2023
CHANGELOG.md
Outdated
| @@ -122,6 +122,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| - [Segment Replication] Fix for peer recovery ([#5344](https://github.com/opensearch-project/OpenSearch/pull/5344)) | |||
| - Fix weighted shard routing state across search requests([#6004](https://github.com/opensearch-project/OpenSearch/pull/6004)) | |||
| - [Segment Replication] Fix bug where inaccurate sequence numbers are sent during replication ([#6122](https://github.com/opensearch-project/OpenSearch/pull/6122)) | |||
| - [Weighted Routing] Fix inconsistent cluster state and ensure weigh away exception check only for data nodes ([#6327](https://github.com/opensearch-project/OpenSearch/pull/6327)) | |||
There was a problem hiding this comment.
lets skip this as it is not a user facing change.
20 tasks
gbbafna
approved these changes
Feb 16, 2023
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
anshu1106
force-pushed
the
cluster-health-state-fix
branch
from
f0bc61d
to
68d8a0c
Compare
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
approved these changes
Feb 21, 2023
Bukhtawar
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes inconsistent cluster state with ensure_weighed_in param while make cluster health api call.
Also adds support for weighed away health check only for data nodes.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.