-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Get SeqNo from Segment Info and integ tests for restore flow #6067
Conversation
Gradle Check (Jenkins) Run Completed with:
|
assert indexShard.getEngine() instanceof InternalEngine : "Expected shard with InternalEngine, got: " | ||
+ indexShard.getEngine().getClass(); | ||
final long lastRefreshedCheckpoint = ((InternalEngine) indexShard.getEngine()).lastRefreshedCheckpoint(); | ||
final long lastRefreshedCheckpoint = indexShard.getEngine().getMaxSeqNoFromSegmentInfos(segmentInfosSnapshot); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should rename lastRefreshedCheckpoint
to maxSeqNoFromSegmentIfnos
?
ensureYellowAndNoInitializingShards(INDEX_NAME); | ||
ensureGreen(INDEX_NAME); | ||
|
||
Map<String, Long> indexStats = indexData(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we sure that remote segment store is up to date here ? Should we check the local fs , in case we don't have any stats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We trigger explicit refresh
/flush
which calls RemoteStoreRefreshListener in the same flow. So, if remote store is available, the segments should be uploaded. Test failure means some problem with the code and we need to fix it.
1afdc3e
to
6888f87
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
6888f87
to
96a1678
Compare
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6067 +/- ##
============================================
- Coverage 70.90% 70.74% -0.16%
+ Complexity 58904 58799 -105
============================================
Files 4778 4778
Lines 281149 281150 +1
Branches 40622 40622
============================================
- Hits 199346 198906 -440
- Misses 65480 65881 +401
- Partials 16323 16363 +40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…e flow (#6067) (#6171) * Get SeqNo from Segment Info and add integ tests for restore flow from remote store Signed-off-by: Sachin Kale <kalsac@amazon.com> (cherry picked from commit f01d3d2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…e flow (opensearch-project#6067) * Get SeqNo from Segment Info and add integ tests for restore flow from remote store Signed-off-by: Sachin Kale <kalsac@amazon.com>
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.