[Remote Store] Get SeqNo from Segment Info and integ tests for restore flow #6067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinpkale
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
reviewed
Feb 2, 2023
| assert indexShard.getEngine() instanceof InternalEngine : "Expected shard with InternalEngine, got: " | ||
| + indexShard.getEngine().getClass(); | ||
| final long lastRefreshedCheckpoint = ((InternalEngine) indexShard.getEngine()).lastRefreshedCheckpoint(); | ||
| final long lastRefreshedCheckpoint = indexShard.getEngine().getMaxSeqNoFromSegmentInfos(segmentInfosSnapshot); |
There was a problem hiding this comment.
we should rename lastRefreshedCheckpoint to maxSeqNoFromSegmentIfnos ?
| ensureYellowAndNoInitializingShards(INDEX_NAME); | ||
| ensureGreen(INDEX_NAME); | ||
|
|
||
| Map<String, Long> indexStats = indexData(); |
There was a problem hiding this comment.
how do we sure that remote segment store is up to date here ? Should we check the local fs , in case we don't have any stats.
There was a problem hiding this comment.
We trigger explicit refresh/flush which calls RemoteStoreRefreshListener in the same flow. So, if remote store is available, the segments should be uploaded. Test failure means some problem with the code and we need to fix it.
sachinpkale
force-pushed
the
remote-store-it
branch
from
1afdc3e
to
6888f87
Compare
Gradle Check (Jenkins) Run Completed with:
|
added 2 commits
February 3, 2023 10:00
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
sachinpkale
force-pushed
the
remote-store-it
branch
from
6888f87
to
96a1678
Compare
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6067 +/- ##
============================================
- Coverage 70.90% 70.74% -0.16%
+ Complexity 58904 58799 -105
============================================
Files 4778 4778
Lines 281149 281150 +1
Branches 40622 40622
============================================
- Hits 199346 198906 -440
- Misses 65480 65881 +401
- Partials 16323 16363 +40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gbbafna
changed the title
gbbafna
approved these changes
Feb 3, 2023
kotwanikunal
pushed a commit
that referenced
this pull request
Feb 3, 2023
…e flow (#6067) (#6171) * Get SeqNo from Segment Info and add integ tests for restore flow from remote store Signed-off-by: Sachin Kale <kalsac@amazon.com> (cherry picked from commit f01d3d2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2
pushed a commit
to mch2/OpenSearch
that referenced
this pull request
Mar 4, 2023
…e flow (opensearch-project#6067) * Get SeqNo from Segment Info and add integ tests for restore flow from remote store Signed-off-by: Sachin Kale <kalsac@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.