[Weighted Routing] Support for fail open stats #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
anshu1106
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
anshu1106
changed the title
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
reviewed
Jan 27, 2023
| * | ||
| * @opensearch.internal | ||
| */ | ||
| public class FailOpenWeightedRoutingStats implements ToXContentFragment, Writeable { |
There was a problem hiding this comment.
Can we define a generic weighted shard robin stats
There was a problem hiding this comment.
Makes sense. Updated
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
reviewed
Jan 30, 2023
Comment on lines
+130
to
+131
| @Nullable | ||
| private WeightedRoutingStats weightedRoutingStats; |
There was a problem hiding this comment.
Since this is only related to Search, does it make sense to be placed in SearchStats instead ?
There was a problem hiding this comment.
Yeah makes sense. Tried to go through the flow but looks like since failopen stats is captured inside FetchPhase, there isn't an easy way to capture this since the current implementation is just looking for fetchphase https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/shard/SearchOperationListener.java. Will require some deeper understanding in this as we need to capture fail open stats in all the actions modified in https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/shard/SearchOperationListener.java. Do you have any pointers on this?
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
reviewed
Jan 31, 2023
| @@ -162,6 +166,11 @@ public NodeStats(StreamInput in) throws IOException { | |||
| } else { | |||
| clusterManagerThrottlingStats = null; | |||
| } | |||
| if (in.getVersion().onOrAfter(Version.CURRENT)) { | |||
There was a problem hiding this comment.
mixed cluster tests fail with 2_6. https://build.ci.opensearch.org/job/gradle-check/10046/
| @@ -356,6 +371,9 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| if (out.getVersion().onOrAfter(Version.V_2_6_0)) { | |||
| out.writeOptionalWriteable(clusterManagerThrottlingStats); | |||
| } | |||
| if (out.getVersion().onOrAfter(Version.CURRENT)) { | |||
There was a problem hiding this comment.
mixed cluster tests fail with 2_6. https://build.ci.opensearch.org/job/gradle-check/10046/
| @@ -46,6 +46,8 @@ public static FailAwareWeightedRouting getInstance() { | |||
| return INSTANCE; | |||
| } | |||
|
|
|||
| public static WeightedRoutingStats weightedRoutingStats = new WeightedRoutingStats(); | |||
There was a problem hiding this comment.
public static member variables have caps on
| // number of times fail open has to be executed for search requests | ||
| private AtomicInteger failOpenCount; | ||
|
|
||
| public WeightedRoutingStats() { |
There was a problem hiding this comment.
Can we create a singleton instance in this class that can be shared across consumers
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6041 +/- ##
============================================
- Coverage 70.77% 70.66% -0.12%
+ Complexity 58744 58643 -101
============================================
Files 4775 4776 +1
Lines 281000 281042 +42
Branches 40592 40597 +5
============================================
- Hits 198873 198586 -287
- Misses 65812 66080 +268
- Partials 16315 16376 +61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
anshu1106
force-pushed
the
wrr-failopen-stats
branch
from
b147164
to
45bcc6e
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
|
Bukhtawar
reviewed
Feb 1, 2023
Comment on lines
+81
to
+84
| public void resetFailOpenCount() { | ||
| failOpenCount.set(0); | ||
| } | ||
| } |
There was a problem hiding this comment.
won't compile since test is in a different package.
Bukhtawar
approved these changes
Feb 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
* Support for fail open stats Signed-off-by: Anshu Agarwal <anshukag@amazon.com> (cherry picked from commit 26ec5fc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Feb 1, 2023
* [Weighted Routing] Support for fail open stats (#6041) * Support for fail open stats Signed-off-by: Anshu Agarwal <anshukag@amazon.com> (cherry picked from commit 26ec5fc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix weighted routing stats version (#6128) Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Co-authored-by: Anshu Agarwal <anshukag@amazon.com> --------- Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anshu Agarwal <anshuagarwal11@gmail.com> Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anshu Agarwal anshukag@amazon.com
Description
This PR adds support to capture fail open stats. Currently it captures number of times fail open is executed for search requests using weighted shard routing.
Issues Resolved
#5037
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.