Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Enhance CheckpointState to support no-op replication (#5282) #5729

Closed
wants to merge 2 commits into from

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Jan 6, 2023

Description

Original PR - #5282

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…d replica (opensearch-project#4954)

* Add RecoverySourceHandlerFactory for extensibility

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* recoverToTarget made extensible to allow multiple implementations

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Remove PRRL after SendFileStep in Peer Recovery

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Remove CHANGELOG entry as this is incremental PR

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Signed-off-by: Ashish Singh <ssashish@amazon.com>
…ect#5282)

* CheckpointState enhanced to support no-op replication

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Bukhtawar Khan<bukhtawa@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5729 (47d7485) into 2.x (85b85b1) will increase coverage by 0.12%.
The diff coverage is 81.75%.

@@             Coverage Diff              @@
##                2.x    #5729      +/-   ##
============================================
+ Coverage     70.53%   70.65%   +0.12%     
- Complexity    58612    58726     +114     
============================================
  Files          4741     4750       +9     
  Lines        280588   280727     +139     
  Branches      40894    40907      +13     
============================================
+ Hits         197918   198360     +442     
+ Misses        66152    65855     -297     
+ Partials      16518    16512       -6     
Impacted Files Coverage Δ
...eplication/checkpoint/PublishCheckpointAction.java 22.41% <0.00%> (-1.23%) ⬇️
...n/support/replication/ReplicationProxyFactory.java 25.00% <25.00%> (ø)
...ensearch/action/bulk/TransportShardBulkAction.java 78.32% <33.33%> (-1.29%) ⬇️
...upport/replication/TransportReplicationAction.java 77.43% <60.00%> (+0.93%) ⬆️
...org/opensearch/index/seqno/ReplicationTracker.java 68.33% <66.66%> (+0.03%) ⬆️
...recovery/RemoteStorePeerRecoverySourceHandler.java 77.77% <77.77%> (ø)
...h/action/support/replication/ReplicationProxy.java 80.00% <80.00%> (ø)
.../recovery/LocalStorePeerRecoverySourceHandler.java 82.95% <82.95%> (ø)
...support/replication/ReplicationModeAwareProxy.java 90.00% <90.00%> (ø)
...search/indices/recovery/RecoverySourceHandler.java 79.71% <90.90%> (+3.10%) ⬆️
... and 499 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashking94 ashking94 closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants