Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Bug] fix case sensitivity for wildcard queries #5493

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ce25dec from #5462.

Fixes the wildcard query to not normalize the pattern when case_insensitive is
set by the user. This is achieved by creating a new normalizedWildcardQuery
method so that query_string queries (which do not support case sensitivity) can
still normalize the pattern when the default analyzer is used; maintaining
existing behavior.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit ce25dec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners December 8, 2022 15:07
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5493 (924dd46) into 2.x (fd59008) will increase coverage by 0.05%.
The diff coverage is 44.44%.

@@             Coverage Diff              @@
##                2.x    #5493      +/-   ##
============================================
+ Coverage     70.61%   70.66%   +0.05%     
- Complexity    58334    58378      +44     
============================================
  Files          4700     4700              
  Lines        279095   279100       +5     
  Branches      40753    40753              
============================================
+ Hits         197076   197221     +145     
+ Misses        65589    65465     -124     
+ Partials      16430    16414      -16     
Impacted Files Coverage Δ
...rg/opensearch/index/mapper/KeywordFieldMapper.java 86.04% <0.00%> (-0.51%) ⬇️
...a/org/opensearch/index/mapper/MappedFieldType.java 74.74% <25.00%> (-3.61%) ⬇️
...a/org/opensearch/index/mapper/StringFieldType.java 85.07% <66.66%> (-4.16%) ⬇️
...pensearch/index/search/QueryStringQueryParser.java 69.94% <100.00%> (-0.54%) ⬇️
...ava/org/opensearch/action/NoSuchNodeException.java 0.00% <0.00%> (-50.00%) ⬇️
...ch/transport/ReceiveTimeoutTransportException.java 50.00% <0.00%> (-50.00%) ⬇️
.../action/admin/indices/flush/ShardFlushRequest.java 50.00% <0.00%> (-50.00%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 60.00% <0.00%> (-40.00%) ⬇️
...luster/routing/allocation/RoutingExplanations.java 62.06% <0.00%> (-37.94%) ⬇️
...earch/action/admin/indices/flush/FlushRequest.java 52.17% <0.00%> (-34.79%) ⬇️
... and 461 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reta reta merged commit 2a1e734 into 2.x Dec 8, 2022
@github-actions github-actions bot deleted the backport/backport-5462-to-2.x branch December 8, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants