Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Update Gradle to 7.6 #5382

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 25, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Update Gradle to 7.6

Issues Resolved

Backport of #5381 to 2.x

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner November 25, 2022 20:04
@reta reta requested a review from andrross November 25, 2022 20:04
@reta reta added the backport PRs or issues specific to backporting features or enhancments label Nov 25, 2022
@reta reta changed the title Update Gradle to 7.6 [Backport] [2.x] Update Gradle to 7.6 Nov 25, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator Author

reta commented Nov 25, 2022

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE x

* **URL:** https://build.ci.opensearch.org/job/gradle-check/7351/

* **CommitID:** [58bfa0b](https://github.com/opensearch-project/OpenSearch/commit/58bfa0bab46259f555457ca1944efea4f0c1e6c9)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

It seem like Gradle Retry plugin is not compatible with Gradle 7.6? :D :`(

> Receiver class org.gradle.testretry.internal.executer.RetryTestResultProcessor does not define or inherit an implementation of the resolved method 'abstract void failure(java.lang.Object, org.gradle.api.tasks.testing.TestFailure)' of interface org.gradle.api.internal.tasks.testing.TestResultProcessor.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member

I just opened #5383 to update test-retry on the 2.x branch to be in line with main. Gradle 7.6 support was added in test-retry 1.4.0.

@reta
Copy link
Collaborator Author

reta commented Nov 25, 2022

I just opened #5383 to update test-retry on the 2.x branch to be in line with main. Gradle 7.6 support was added in test-retry 1.4.0.

I did it here as well, do you want to spit it in several commits? This guy seems to be green and ready to merge :)

@andrross
Copy link
Member

I just opened #5383 to update test-retry on the 2.x branch to be in line with main. Gradle 7.6 support was added in test-retry 1.4.0.

I did it here as well, do you want to spit it in several commits? This guy seems to be green and ready to merge :)

I don't see the test-retry upgrade in this PR? Am I missing it?

@reta
Copy link
Collaborator Author

reta commented Nov 25, 2022

I just opened #5383 to update test-retry on the 2.x branch to be in line with main. Gradle 7.6 support was added in test-retry 1.4.0.

I did it here as well, do you want to spit it in several commits? This guy seems to be green and ready to merge :)

I don't see the test-retry upgrade in this PR? Am I missing it?

Oops, sorry about it, I did the change but forgot to push, apologies

@reta
Copy link
Collaborator Author

reta commented Nov 25, 2022

I just opened #5383 to update test-retry on the 2.x branch to be in line with main. Gradle 7.6 support was added in test-retry 1.4.0.

Approved, thank you!

@andrross andrross merged commit 9c68587 into opensearch-project:2.x Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants