Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] copy build.sh over from opensearch-build #4989

Merged

Conversation

rursprung
Copy link
Contributor

@rursprung rursprung commented Oct 31, 2022

the build script should be located in this repository instead of centrally in opensearch-build to allow per-branch specific builds (newer versions might have newer requirements, which currently cannot be reflected).

the file was copied 1:1 from scripts/components/OpenSearch/build.sh as of commit 9e1aa38 in the opensearch-build repository.

this is part of opensearch-build#99 and needs to be backported to all active branches because the file here will only be used by the build once the central one in opensearch-build has been removed which in turn can only happen when all active branches have the build.sh.

Signed-off-by: Ralph Ursprung Ralph.Ursprung@avaloq.com

Signed-off-by: Ralph Ursprung Ralph.Ursprung@avaloq.com
(cherry picked from commit e357246)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

the build script should be located in this repository instead of
centrally in [opensearch-build][] to allow per-branch specific builds
(newer versions might have newer requirements, which currently cannot be
reflected).

the file was copied 1:1 from `scripts/components/OpenSearch/build.sh` as
of commit 9e1aa38 in the [opensearch-build][] repository.

this is part of opensearch-build#99 and needs to be backported to all
active branches because the file here will only be used by the build
once the central one in opensearch-build has been removed which in turn
can only happen when all active branches have the `build.sh`.

[opensearch-build]: https://github.com/opensearch-project/opensearch-build

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
(cherry picked from commit e357246)
@rursprung rursprung requested review from a team and reta as code owners October 31, 2022 11:00
@rursprung rursprung changed the title copy build.sh over from opensearch-build (#4887) [Backport 1.x] copy build.sh over from opensearch-build Oct 31, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta added the backport PRs or issues specific to backporting features or enhancments label Oct 31, 2022
@reta reta merged commit d05ff9a into opensearch-project:1.x Oct 31, 2022
@rursprung rursprung deleted the backport/backport-4887-to-1.x branch October 31, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants