-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alternate example data in OpenSearch test cases. #454
Use alternate example data in OpenSearch test cases. #454
Conversation
✅ DCO Check Passed cb0833a1c0b29a740de71b27c7fd81afaa150d37 |
✅ Gradle Wrapper Validation success cb0833a1c0b29a740de71b27c7fd81afaa150d37 |
✅ Gradle Precommit success cb0833a1c0b29a740de71b27c7fd81afaa150d37 |
✅ DCO Check Passed 030abe67eae71886e0eb6bf7bf1418d364bf5eea |
✅ Gradle Wrapper Validation success 030abe67eae71886e0eb6bf7bf1418d364bf5eea |
✅ Gradle Precommit success 030abe67eae71886e0eb6bf7bf1418d364bf5eea |
This commit updates some of the sample test data used in test cases in OpenSearch. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
✅ Gradle Wrapper Validation success 25ba05b |
✅ DCO Check Passed 25ba05b |
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
✅ DCO Check Passed 31f41ca |
✅ Gradle Wrapper Validation success 31f41ca |
✅ Gradle Precommit success 25ba05b |
✅ Gradle Precommit success 31f41ca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some other real aliases that we should scrub. I just grabbed more metasyntactic variables
...t/rest-high-level/src/test/java/org/opensearch/client/documentation/CRUDDocumentationIT.java
Outdated
Show resolved
Hide resolved
...high-level/src/test/java/org/opensearch/client/documentation/QueryDSLDocumentationTests.java
Outdated
Show resolved
Hide resolved
...rest-high-level/src/test/java/org/opensearch/client/documentation/SearchDocumentationIT.java
Outdated
Show resolved
Hide resolved
...rest-high-level/src/test/java/org/opensearch/client/documentation/SearchDocumentationIT.java
Outdated
Show resolved
Hide resolved
...rest-high-level/src/test/java/org/opensearch/client/documentation/SearchDocumentationIT.java
Outdated
Show resolved
Hide resolved
...rest-high-level/src/test/java/org/opensearch/client/documentation/SearchDocumentationIT.java
Outdated
Show resolved
Hide resolved
...rest-high-level/src/test/java/org/opensearch/client/documentation/SearchDocumentationIT.java
Outdated
Show resolved
Hide resolved
...rest-high-level/src/test/java/org/opensearch/client/documentation/SearchDocumentationIT.java
Outdated
Show resolved
Hide resolved
...rest-high-level/src/test/java/org/opensearch/client/documentation/SearchDocumentationIT.java
Outdated
Show resolved
Hide resolved
...rest-high-level/src/test/java/org/opensearch/client/documentation/SearchDocumentationIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
✅ Gradle Wrapper Validation success 2ebf0d6 |
✅ DCO Check Passed 2ebf0d6 |
✅ Gradle Precommit success 2ebf0d6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Don't forget to backport to 1.x! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, please merge, I will close #456 .
This PR replaces some example data used in Elasticsearch.
As a result of this change, some test failures are also fixed which were failing due to incomplete renaming in test data and expected values in test cases.
Relates #441
Signed-off-by: Rabi Panda adnapibar@gmail.com