Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Revert to Netty 4.1.79.Final #4441

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Sep 7, 2022

Signed-off-by: Craig Perkins cwperx@amazon.com

Description

See related issue: #4427

The last minor version of Netty included a change to eagerly load certificates using BouncyCastle if BouncyCastle is on the classpath: netty/netty#12670

This change has led to errors on startup with the security plugin (See #4427) because of a bug in checking all required BouncyCastle dependencies (See netty/netty#12743)

There is another bug related to the change that impacts custom bundles for private keys (netty/netty#12746). Both bugs have since been fixed and are targeted for the next 4.1.X release of netty.

This PR reverts netty until the next 4.1.X (4.1.81.Final) release. The full list of changes in netty 4.1.80.Final can be found here

Issues Resolved

#4427

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit fb64a85)
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks mentioned this pull request Sep 7, 2022
6 tasks
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4441 (4c42879) into 1.x (f757633) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.x    #4441      +/-   ##
============================================
+ Coverage     77.89%   77.92%   +0.02%     
+ Complexity    63449    63445       -4     
============================================
  Files          4453     4453              
  Lines        275009   275009              
  Branches      41172    41172              
============================================
+ Hits         214207   214289      +82     
+ Misses        43926    43804     -122     
- Partials      16876    16916      +40     
Impacted Files Coverage Δ
...nsearch/indices/recovery/PeerRecoveryNotFound.java 0.00% <0.00%> (-100.00%) ⬇️
...nsearch/search/dfs/DfsPhaseExecutionException.java 0.00% <0.00%> (-66.67%) ⬇️
...a/org/opensearch/client/cluster/ProxyModeInfo.java 0.00% <0.00%> (-63.16%) ⬇️
...port/ResponseHandlerFailureTransportException.java 0.00% <0.00%> (-60.00%) ⬇️
...earch/index/engine/FlushFailedEngineException.java 50.00% <0.00%> (-50.00%) ⬇️
.../action/ingest/SimulatePipelineRequestBuilder.java 0.00% <0.00%> (-50.00%) ⬇️
...gling/import_index/ImportDanglingIndexRequest.java 43.75% <0.00%> (-50.00%) ⬇️
...c/main/java/org/opensearch/geometry/MultiLine.java 80.00% <0.00%> (-20.00%) ⬇️
...rc/main/java/org/opensearch/monitor/os/OsInfo.java 64.70% <0.00%> (-19.61%) ⬇️
...tion/termvectors/MultiTermVectorsItemResponse.java 64.51% <0.00%> (-19.36%) ⬇️
... and 405 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reta reta merged commit e964fc2 into opensearch-project:1.x Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants