Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Segment Replication] Bump segment infos counter before commit during replica promotion #4397

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

dreamer-89
Copy link
Member

Manual backport of #4365

… replica promotion (opensearch-project#4365)

* [Segment Replication] Bump segment infos counter before commit during replica promotion

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Add changelog entry

Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89 dreamer-89 requested review from a team and reta as code owners September 2, 2022 20:07
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4397 (5ded950) into 2.x (1edb733) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #4397      +/-   ##
============================================
- Coverage     70.72%   70.68%   -0.05%     
+ Complexity    57166    57134      -32     
============================================
  Files          4584     4584              
  Lines        274484   274486       +2     
  Branches      40223    40223              
============================================
- Hits         194137   194009     -128     
- Misses        64111    64195      +84     
- Partials      16236    16282      +46     
Impacted Files Coverage Δ
.../opensearch/index/engine/NRTReplicationEngine.java 75.83% <100.00%> (+0.32%) ⬆️
...g/opensearch/index/analysis/CharFilterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
.../org/opensearch/client/indices/AnalyzeRequest.java 31.00% <0.00%> (-47.00%) ⬇️
...regations/metrics/AbstractHyperLogLogPlusPlus.java 51.72% <0.00%> (-44.83%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
...cluster/coordination/PublishClusterStateStats.java 33.33% <0.00%> (-37.51%) ⬇️
...ion/admin/cluster/node/info/PluginsAndModules.java 53.12% <0.00%> (-34.38%) ⬇️
...pensearch/client/core/MultiTermVectorsRequest.java 41.17% <0.00%> (-29.42%) ⬇️
...rc/main/java/org/opensearch/ingest/IngestInfo.java 51.72% <0.00%> (-27.59%) ⬇️
...va/org/opensearch/client/sniff/SnifferBuilder.java 72.72% <0.00%> (-27.28%) ⬇️
... and 475 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mch2 mch2 merged commit 5985955 into opensearch-project:2.x Sep 3, 2022
@dreamer-89 dreamer-89 changed the title [Segment Replication] Bump segment infos counter before commit during replica promotion [Backport 2.x] [Segment Replication] Bump segment infos counter before commit during replica promotion Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants