Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Change license header and copyright notice to SPDX #437

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Mar 22, 2021

This PR changes the oss-license-header.txt file from the legacy ASLv2 header
to the new SPDX format. It also updates the ide gradle file and
LicenseHeaderTask of precommit to accept the new SPDX license format.

relates #160
closes #155

@nknize nknize added >FORK Related to the fork process Rename Renaming to OpenSearch labels Mar 22, 2021
@nknize nknize requested a review from CEHENKLE March 22, 2021 04:14
substringMatcher(licenseFamilyCategory: "SPDX ",
licenseFamilyName: "SPDX") {
// Apache license (ES)
pattern(substring: "Copyright OpenSearch Contributors.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be Copyright 2021 OpenSearch Contributors?

Copy link
Collaborator Author

@nknize nknize Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it was generally advised that the year is not needed in the header so it was intentionally left off

@odfe-release-bot
Copy link

✅   DCO Check Passed

1 similar comment
@odfe-release-bot
Copy link

✅   DCO Check Passed

@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Member

@CEHENKLE CEHENKLE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

This commit changes the oss-license-header.txt file from the legacy ASLv2 header
to the new SPDX format. It also updates the ide gradle file and
LicenseHeaderTask of precommit to accept the new SPDX license format.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@odfe-release-bot
Copy link

✅   DCO Check Passed

@nknize nknize merged commit 4990779 into opensearch-project:main Mar 22, 2021
@dhwanilpatel dhwanilpatel mentioned this pull request Apr 6, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DISCUSS] Review new license header
4 participants