Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment Replication - Implement segment replication event cancellation. #4225

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Segment Replication - Implement segment replication event cancellation. #4225

merged 2 commits into from
Aug 31, 2022

Commits on Aug 31, 2022

  1. Segment Replication. Fix Cancellation of replication events. 

    This PR updates segment replication paths to correctly cancel replication events on the primary and replica.
In the source service, any ongoing event for a primary that is sending to a replica that shuts down or is promoted as a new primary are cancelled.
In the target service, any ongoing event for a replica that is promoted as a new primary or is fetching from a primary that shuts down.
It wires up SegmentReplicationSourceService as an IndexEventListener so that it can respond to events and cancel any ongoing transfer state.
This change also includes some test cleanup for segment replication to rely on actual components over mocks.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Fix to not start/stop SegmentReplicationSourceService as a lifecycle component with feature flag off.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Update logic to properly mark SegmentReplicationTarget as cancelled when cancel initiated by primary.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Minor updates from self review.

Signed-off-by: Marc Handalian <handalm@amazon.com>
    @mch2
    mch2 committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    18d16b3 View commit details
    Browse the repository at this point in the history

  2. Add missing changelog entry. 

    Signed-off-by: Marc Handalian <handalm@amazon.com>
    @mch2
    mch2 committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    a63ec6b View commit details
    Browse the repository at this point in the history