Rename remaining org.elasticsearch.* #422
Conversation
Signed-off-by: Harold Wang <harowang@amazon.com>
harold-wang
added
>FORK
|
✅ DCO Check Passed |
| @@ -24,7 +24,7 @@ | |||
| import com.sun.net.httpserver.HttpsConfigurator; | |||
| import com.sun.net.httpserver.HttpsServer; | |||
| import org.apache.http.HttpHost; | |||
| import org.elasticsearch.mocksocket.MockHttpServer; | |||
There was a problem hiding this comment.
We have knowingly left this as @saratvemulapalli is working on the dependencies and he will update this when the artifacts are ready. same for all others.
| @@ -84,14 +84,14 @@ To for example start the open source distribution: | |||
| Run a single test case (variants) | |||
There was a problem hiding this comment.
This is being done in a separate PR #390
There was a problem hiding this comment.
@adnapibar I see #390 only cover the testingascii.doc, will client/sniffer/src/test/java/org/opensearch/client/sniff/OpenSearchNodesSnifferTests.java be covered by #390?
There was a problem hiding this comment.
@saratvemulapalli and @adnapibar Please confirm if #390 will cover both TESTING.asciidoc and remove all existing "import org.elasticsearch.*".
There was a problem hiding this comment.
PR #390 will only cover the doc but the code changes have to be done by us, if thats not done yet.
There was a problem hiding this comment.
@saratvemulapalli, OK, not sure if it is OK to keep "import org.elasticsearch.mocksocket.MockHttpServer"(still in code) I I think MockHttpServer is from Elastic Co.
There was a problem hiding this comment.
@adnapibar I see #390 only cover the testingascii.doc, will client/sniffer/src/test/java/org/opensearch/client/sniff/OpenSearchNodesSnifferTests.java be covered by #390?
This code change is not required at this moment (as mentioned in my earlier comment)
There was a problem hiding this comment.
ok, clear enough.
|
Closed based on communication with Rabi and Sarat. |
Rename remaining org.elasicsearch.*
relates #160
Signed-off-by: Harold Wang harowang@amazon.com