Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Fix imports in the modules directory. #386

Merged
merged 1 commit into from
Mar 18, 2021
Merged

[Rename] Fix imports in the modules directory. #386

merged 1 commit into from
Mar 18, 2021

Conversation

adnapibar
Copy link
Contributor

Relates #160

Fix import issues in the modules directory resulting from the refactoring.

Signed-off-by: Rabi Panda adnapibar@gmail.com

@adnapibar adnapibar added >FORK Related to the fork process Rename Renaming to OpenSearch labels Mar 18, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Contributor

@harold-wang harold-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except the 3 single comments I added. thanks

Copy link
Contributor

@harold-wang harold-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change!

Fix import issues in the modules directory resulting from the refactoring.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@adnapibar adnapibar merged commit 394f408 into opensearch-project:rename/opensearch Mar 18, 2021
@adnapibar adnapibar deleted the rename/modules/fix-imports branch March 18, 2021 22:57
nknize pushed a commit that referenced this pull request Mar 20, 2021
Fix import issues in the modules directory resulting from the refactoring.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
nknize pushed a commit that referenced this pull request Mar 22, 2021
Fix import issues in the modules directory resulting from the refactoring.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants