-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradle check test for github workflows (Testing again) #3717
Conversation
repository-s3
|
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
d72e352
to
5f599f6
Compare
Gradle check on main branch success after changing to 128CPU setup: 2.0 as well: https://build.ci.opensearch.org/job/gradle-check/13/console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@peterzhuamazon are we planning to remove ci-bot comments as a part of this PR? |
This is old workflow @owaiskazi19 have nothing to do with the new one. |
Yes. So are we planning to remove the old workflow or do we have any issue to track it? |
@dreamer-89 new workflow has much higher stable rate compares to old one, success again. The old one is failure miserably during a test, flaky integTest. |
Per our offline conversation I already stated I am going to disable it once we merge this. |
Seems like still need to present on these old branches, backport them. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-3717-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 660cc11612ee8d9380f6944a212cfdd66a86d36a
# Push it to GitHub
git push --set-upstream origin backport/backport-3717-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-3717-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 660cc11612ee8d9380f6944a212cfdd66a86d36a
# Push it to GitHub
git push --set-upstream origin backport/backport-3717-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0 Then, create a pull request where the |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 660cc11)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport/backport-3717-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 660cc11612ee8d9380f6944a212cfdd66a86d36a
# Push it to GitHub
git push --set-upstream origin backport/backport-3717-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-3717-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 660cc11612ee8d9380f6944a212cfdd66a86d36a
# Push it to GitHub
git push --set-upstream origin backport/backport-3717-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 660cc11)
Could we try https://github.com/marketplace/actions/trigger-jenkins-job instead of huge amount of boilerplate scripting here? |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Add gradle check test for github workflows (Testing again)
Issues Resolved
opensearch-project/opensearch-build#851
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.