[Rename] o.e.common subpackages round 1 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed |
1 similar comment
|
✅ DCO Check Passed |
This commit refactors the following subpackages of o.e.common: * o.e.common.joda * o.e.common.lease * o.e.common.metrics * o.e.common.network * o.e.common.path * o.e.common.recycling * o.e.common.regex * o.e.common.rounding * o.e.common.text * o.e.common.time * o.e.common.transport to the o.opensearch namespace. All references throughout the codebase have been refactored. Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Nicholas Knize <nknize@amazon.com>
nknize
force-pushed
the
rename/server/common/subpackages4
branch
from
b89de19
to
c0045f3
Compare
|
✅ DCO Check Passed |
setiah
reviewed
Mar 16, 2021
| @@ -7,7 +7,7 @@ | |||
| * not use this file except in compliance with the License. | |||
| * You may obtain a copy of the License at | |||
| * | |||
| * http://www.apache.org/licenses/LICENSE-2.0 | |||
| * http://www.apache.org/licenses/LICENSE-2.0 | |||
There was a problem hiding this comment.
nit: Intellij adds some unwanted whitespacing sometimes. I use below command to remove whitespaces before committing
git diff -w > foo.patch && git checkout . && git apply foo.patch && rm foo.patch
There was a problem hiding this comment.
I also noticed these whitespaces aren't actually committed despite showing up in the diff. It's strange but we've been able to ignore these as a result.
There was a problem hiding this comment.
Oic, didn't know this. Thanks!
setiah
reviewed
Mar 16, 2021
| @@ -225,7 +225,7 @@ private static boolean isUp(final NetworkInterface intf) throws IOException { | |||
| } | |||
| return list.toArray(new InetAddress[list.size()]); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
git diff -w > foo.patch && git checkout . && git apply foo.patch && rm foo.patch can remove this too.
|
Thanks @nknize. LGTM! |
nknize
added a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] o.e.common subpackages round 1 This commit refactors the following subpackages of o.e.common: * o.e.common.joda * o.e.common.lease * o.e.common.metrics * o.e.common.network * o.e.common.path * o.e.common.recycling * o.e.common.regex * o.e.common.rounding * o.e.common.text * o.e.common.time * o.e.common.transport to the o.opensearch namespace. All references throughout the codebase have been refactored. Signed-off-by: Nicholas Knize <nknize@amazon.com> * fix imports 1 Signed-off-by: Nicholas Knize <nknize@amazon.com>
nknize
added a commit
that referenced
this pull request
Mar 22, 2021
* [Rename] o.e.common subpackages round 1 This commit refactors the following subpackages of o.e.common: * o.e.common.joda * o.e.common.lease * o.e.common.metrics * o.e.common.network * o.e.common.path * o.e.common.recycling * o.e.common.regex * o.e.common.rounding * o.e.common.text * o.e.common.time * o.e.common.transport to the o.opensearch namespace. All references throughout the codebase have been refactored. Signed-off-by: Nicholas Knize <nknize@amazon.com> * fix imports 1 Signed-off-by: Nicholas Knize <nknize@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the following subpackages of o.e.common:
to the o.opensearch namespace. All references throughout the codebase have been
refactored.
relates #160