-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] o.e.common subpackages round 1 #332
[Rename] o.e.common subpackages round 1 #332
Conversation
✅ DCO Check Passed |
1 similar comment
✅ DCO Check Passed |
This commit refactors the following subpackages of o.e.common: * o.e.common.joda * o.e.common.lease * o.e.common.metrics * o.e.common.network * o.e.common.path * o.e.common.recycling * o.e.common.regex * o.e.common.rounding * o.e.common.text * o.e.common.time * o.e.common.transport to the o.opensearch namespace. All references throughout the codebase have been refactored. Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Nicholas Knize <nknize@amazon.com>
b89de19
to
c0045f3
Compare
✅ DCO Check Passed |
@@ -7,7 +7,7 @@ | |||
* not use this file except in compliance with the License. | |||
* You may obtain a copy of the License at | |||
* | |||
* http://www.apache.org/licenses/LICENSE-2.0 | |||
* http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Intellij adds some unwanted whitespacing sometimes. I use below command to remove whitespaces before committing
git diff -w > foo.patch && git checkout . && git apply foo.patch && rm foo.patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed these whitespaces aren't actually committed despite showing up in the diff. It's strange but we've been able to ignore these as a result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oic, didn't know this. Thanks!
@@ -225,7 +225,7 @@ private static boolean isUp(final NetworkInterface intf) throws IOException { | |||
} | |||
return list.toArray(new InetAddress[list.size()]); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git diff -w > foo.patch && git checkout . && git apply foo.patch && rm foo.patch
can remove this too.
Thanks @nknize. LGTM! |
* [Rename] o.e.common subpackages round 1 This commit refactors the following subpackages of o.e.common: * o.e.common.joda * o.e.common.lease * o.e.common.metrics * o.e.common.network * o.e.common.path * o.e.common.recycling * o.e.common.regex * o.e.common.rounding * o.e.common.text * o.e.common.time * o.e.common.transport to the o.opensearch namespace. All references throughout the codebase have been refactored. Signed-off-by: Nicholas Knize <nknize@amazon.com> * fix imports 1 Signed-off-by: Nicholas Knize <nknize@amazon.com>
* [Rename] o.e.common subpackages round 1 This commit refactors the following subpackages of o.e.common: * o.e.common.joda * o.e.common.lease * o.e.common.metrics * o.e.common.network * o.e.common.path * o.e.common.recycling * o.e.common.regex * o.e.common.rounding * o.e.common.text * o.e.common.time * o.e.common.transport to the o.opensearch namespace. All references throughout the codebase have been refactored. Signed-off-by: Nicholas Knize <nknize@amazon.com> * fix imports 1 Signed-off-by: Nicholas Knize <nknize@amazon.com>
This PR refactors the following subpackages of o.e.common:
to the o.opensearch namespace. All references throughout the codebase have been
refactored.
relates #160