Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] o.e.common.geo, hash, io #317

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Mar 16, 2021

This PR refactors the following packages:

  • o.e.common.geo
  • o.e.common.hash
  • o.e.common.io

into the o.opensearch.common namespace. All references throughout the codebase
have been refactored.

relates #160

@nknize nknize added >FORK Related to the fork process Rename Renaming to OpenSearch labels Mar 16, 2021
@nknize
Copy link
Collaborator Author

nknize commented Mar 16, 2021

this one is pretty large. Let me know if anyone would like me to split these into separate PR's

@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Collaborator

@tlfeng tlfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks huge, but there is only class path changes. 😉
Compared to PR 316, although there is only 90 files change, it took me 2.5x time (30 vs 80 min) in reviewing it than the current PR 317.

This commit refactors the following packages:

* o.e.common.geo
* o.e.common.hash
* o.e.common.io

into the o.opensearch.common namespace. All references throughout the codebase
have been refactored.

Signed-off-by: Nicholas Knize <nknize@amazon.com>
@nknize nknize force-pushed the rename/server/common/subpackages3 branch from 2440e36 to a0523a6 Compare March 16, 2021 13:46
Signed-off-by: Nicholas Knize <nknize@amazon.com>
@nknize nknize merged commit 1798477 into opensearch-project:rename/opensearch Mar 16, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed

nknize added a commit that referenced this pull request Mar 20, 2021
This commit refactors the following packages:

* o.e.common.geo
* o.e.common.hash
* o.e.common.io

into the o.opensearch.common namespace. All references throughout the codebase
have been refactored.

Signed-off-by: Nicholas Knize <nknize@amazon.com>
nknize added a commit that referenced this pull request Mar 22, 2021
This commit refactors the following packages:

* o.e.common.geo
* o.e.common.hash
* o.e.common.io

into the o.opensearch.common namespace. All references throughout the codebase
have been refactored.

Signed-off-by: Nicholas Knize <nknize@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants