[Rename] refactor the distribution module. #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed |
tlfeng
reviewed
Mar 16, 2021
tlfeng
reviewed
Mar 16, 2021
tlfeng
reviewed
Mar 16, 2021
tlfeng
reviewed
Mar 16, 2021
|
✅ DCO Check Passed |
tlfeng
reviewed
Mar 16, 2021
distribution/tools/launchers/src/main/java/org/opensearch/tools/launchers/SystemJvmOptions.java
Outdated
Show resolved
Hide resolved
| @@ -756,7 +756,7 @@ public void testContainsIntermediateDirectory() throws Exception { | |||
| Tuple<Path, Environment> env = createEnv(fs, temp); | |||
| Path pluginDir = createPluginDir(temp); | |||
| Files.createFile(pluginDir.resolve(PluginInfo.ES_PLUGIN_PROPERTIES)); | |||
There was a problem hiding this comment.
Do we have plan to rename ES_PLUGIN_PROPERTIES?
There was a problem hiding this comment.
This should be refactored as part of the renaming of the enum.
|
✅ DCO Check Passed |
Thanks a lot @tlfeng for the review 👍 |
tlfeng
approved these changes
Mar 16, 2021
tlfeng
reviewed
Mar 16, 2021
Refactor the `distribution` module to rename elasticsearch to opensearch. The commit doesn't rename the files in the `src/bin` directory as git doesn't detect `git mv`, so that change will be done in a subsequent commit. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
|
✅ DCO Check Passed |
nknize
pushed a commit
that referenced
this pull request
Mar 20, 2021
Refactor the `distribution` module to rename elasticsearch to opensearch. The commit doesn't rename the files in the `src/bin` directory as git doesn't detect `git mv`, so that change will be done in a subsequent commit. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
nknize
pushed a commit
that referenced
this pull request
Mar 22, 2021
Refactor the `distribution` module to rename elasticsearch to opensearch. The commit doesn't rename the files in the `src/bin` directory as git doesn't detect `git mv`, so that change will be done in a subsequent commit. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
ritty27
pushed a commit
to ritty27/OpenSearch
that referenced
this pull request
May 12, 2024
…roject#316) * Bump classgraph from 4.8.152 to 4.8.154 in /java-client Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.8.152 to 4.8.154. - [Release notes](https://github.com/classgraph/classgraph/releases) - [Commits](classgraph/classgraph@classgraph-4.8.152...classgraph-4.8.154) --- updated-dependencies: - dependency-name: io.github.classgraph:classgraph dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #160
Refactor the
distributionmodule to rename elasticsearch to opensearch. The commit doesn't rename the files in thesrc/bindirectory as git doesn't detectgit mv, so that change will be done in a subsequent commit.Signed-off-by: Rabi Panda adnapibar@gmail.com