-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] refactor the distribution module. #316
[Rename] refactor the distribution module. #316
Conversation
✅ DCO Check Passed |
✅ DCO Check Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR was really a tough work for you because it contains so many different pattern to be renamed.. 👍👍
distribution/tools/launchers/src/main/java/org/opensearch/tools/launchers/SystemJvmOptions.java
Outdated
Show resolved
Hide resolved
@@ -756,7 +756,7 @@ public void testContainsIntermediateDirectory() throws Exception { | |||
Tuple<Path, Environment> env = createEnv(fs, temp); | |||
Path pluginDir = createPluginDir(temp); | |||
Files.createFile(pluginDir.resolve(PluginInfo.ES_PLUGIN_PROPERTIES)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have plan to rename ES_PLUGIN_PROPERTIES
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be refactored as part of the renaming of the enum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I see.
✅ DCO Check Passed |
Thanks a lot @tlfeng for the review 👍 |
Refactor the `distribution` module to rename elasticsearch to opensearch. The commit doesn't rename the files in the `src/bin` directory as git doesn't detect `git mv`, so that change will be done in a subsequent commit. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
✅ DCO Check Passed |
Refactor the `distribution` module to rename elasticsearch to opensearch. The commit doesn't rename the files in the `src/bin` directory as git doesn't detect `git mv`, so that change will be done in a subsequent commit. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Refactor the `distribution` module to rename elasticsearch to opensearch. The commit doesn't rename the files in the `src/bin` directory as git doesn't detect `git mv`, so that change will be done in a subsequent commit. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
…roject#316) * Bump classgraph from 4.8.152 to 4.8.154 in /java-client Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.8.152 to 4.8.154. - [Release notes](https://github.com/classgraph/classgraph/releases) - [Commits](classgraph/classgraph@classgraph-4.8.152...classgraph-4.8.154) --- updated-dependencies: - dependency-name: io.github.classgraph:classgraph dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Relates #160
Refactor the
distribution
module to rename elasticsearch to opensearch. The commit doesn't rename the files in thesrc/bin
directory as git doesn't detectgit mv
, so that change will be done in a subsequent commit.Signed-off-by: Rabi Panda adnapibar@gmail.com