Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] server/src/main/java/org/elasticsearch/index #293

Merged
merged 1 commit into from
Mar 12, 2021
Merged

[Rename] server/src/main/java/org/elasticsearch/index #293

merged 1 commit into from
Mar 12, 2021

Conversation

harold-wang
Copy link
Contributor

Issue #160 , if available:

Description of changes:

Refactor folder name only for server/src/main/java/org/elasticsearch/index as part of the OpenSearch renaming effort.

Signed-off-by: Harold Wang harowang@amazon.com

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…src/main/java/org/opensearch/index

Signed-off-by: Harold Wang <harowang@amazon.com>
@harold-wang harold-wang self-assigned this Mar 12, 2021
@harold-wang harold-wang requested a review from tlfeng March 12, 2021 19:50
@harold-wang harold-wang added Rename Renaming to OpenSearch >FORK Related to the fork process labels Mar 12, 2021
@harold-wang
Copy link
Contributor Author

@tianleh this is just changed folder name, thank you!

@adnapibar
Copy link
Contributor

Can you change the package name along with the folder name (and vice versa). And I'd suggest do a proper refactoring so that we can replace the use of these classes as well (it will be tough to do that later).

Copy link
Collaborator

@tlfeng tlfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you make sure these 2 files will be renamed by someone?

EsTieredMergePolicy.java 
ESToParentBlockJoinQuery.java

@tlfeng tlfeng self-requested a review March 12, 2021 20:24
@harold-wang
Copy link
Contributor Author

Looks good, but could you make sure these 2 files will be renamed by someone?

EsTieredMergePolicy.java 
ESToParentBlockJoinQuery.java

I will rename these 2 files, thanks

@harold-wang harold-wang merged commit efe2be9 into opensearch-project:rename/opensearch Mar 12, 2021
@harold-wang
Copy link
Contributor Author

Can you change the package name along with the folder name (and vice versa). And I'd suggest do a proper refactoring so that we can replace the use of these classes as well (it will be tough to do that later).

I feel that renaming root folder and merge it will reduce the conflict, otherwise resolving conflict will waster a lot of time.

nknize pushed a commit that referenced this pull request Mar 22, 2021
…src/main/java/org/opensearch/index (#293)

Signed-off-by: Harold Wang <harowang@amazon.com>
ritty27 pushed a commit to ritty27/OpenSearch that referenced this pull request May 12, 2024
Signed-off-by: Benoit Tellier <btellier@linagora.com>

Signed-off-by: Benoit Tellier <btellier@linagora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants