-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] server/src/main/java/org/elasticsearch/index #293
[Rename] server/src/main/java/org/elasticsearch/index #293
Conversation
…src/main/java/org/opensearch/index Signed-off-by: Harold Wang <harowang@amazon.com>
@tianleh this is just changed folder name, thank you! |
Can you change the package name along with the folder name (and vice versa). And I'd suggest do a proper refactoring so that we can replace the use of these classes as well (it will be tough to do that later). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but could you make sure these 2 files will be renamed by someone?
EsTieredMergePolicy.java
ESToParentBlockJoinQuery.java
I will rename these 2 files, thanks |
I feel that renaming root folder and merge it will reduce the conflict, otherwise resolving conflict will waster a lot of time. |
…src/main/java/org/opensearch/index (#293) Signed-off-by: Harold Wang <harowang@amazon.com>
Signed-off-by: Benoit Tellier <btellier@linagora.com> Signed-off-by: Benoit Tellier <btellier@linagora.com>
Issue #160 , if available:
Description of changes:
Refactor folder name only for server/src/main/java/org/elasticsearch/index as part of the OpenSearch renaming effort.
Signed-off-by: Harold Wang harowang@amazon.com
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.