[Bug] Fix InboundDecoder version compat check #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change InboundDecoder ensureVersionCompatibility check for onOrAfter V_2_0_0 instead of explicit version check. This way bug fix and minor versions will correctly handshake in a mixed 1.x Cluster. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added
bug
|
#1561 failure; refiring. |
|
start gradle check |
saratvemulapalli
approved these changes
Mar 23, 2022
|
#1703 failure; refiring |
|
start gradle check |
nknize
added
backport 2.x
nknize
added a commit
that referenced
this pull request
Mar 23, 2022
Change InboundDecoder ensureVersionCompatibility check for onOrAfter V_2_0_0 instead of explicit version check. This way bug fix and minor versions will correctly handshake in a mixed 1.x Cluster. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit 511ac88)
nknize
added a commit
that referenced
this pull request
Mar 23, 2022
Change InboundDecoder ensureVersionCompatibility check for onOrAfter V_2_0_0 instead of explicit version check. This way bug fix and minor versions will correctly handshake in a mixed 1.x Cluster. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit 511ac88)
nknize
removed
the
pending backport
nknize
pushed a commit
that referenced
this pull request
Mar 23, 2022
Change InboundDecoder ensureVersionCompatibility check for onOrAfter V_2_0_0 instead of explicit version check. This way bug fix and minor versions will correctly handshake in a mixed 1.x Cluster. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit 511ac88)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change InboundDecoder
ensureVersionCompatibilitycheck foronOrAfterV_2_0_0instead of explicit 2.0 check. This way bug fix and minorversions will correctly handshake in a mixed 1.x Cluster.