Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bwcVersions after bumping version 1.3.1 (#2532) #2543

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Mar 21, 2022

Signed-off-by: Nicholas Walter Knize nknize@apache.org
Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Fix bwc tests

Issues Resolved

Backport of #2532

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator Author

reta commented Mar 21, 2022

@dblock @nknize please

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx!

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d5b40e8ab127b5430f1443976d83cc8d11df99e1
Log 3626

Reports 3626

@dblock
Copy link
Member

dblock commented Mar 21, 2022

org.opensearch.upgrade.DetectEsInstallationTaskTests > testTaskExecution FAILED
    java.lang.AssertionError: 
    Expected: a collection with size <0>
         but: collection size was <5>
        at __randomizedtesting.SeedInfo.seed([D13BB0340B7301E1:9B2194BFDF244E64]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.upgrade.DetectEsInstallationTaskTests.testTaskExecution(DetectEsInstallationTaskTests.java:53)
REPRODUCE WITH: ./gradlew ':distribution:tools:upgrade-cli:test' --tests "org.opensearch.upgrade.DetectEsInstallationTaskTests.testTaskExecution" -Dtests.seed=D13BB0340B7301E1 -Dtests.security.manager=false -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sl -Dtests.timezone=Asia/Kolkata -Druntime.java=11

Suite: Test class org.opensearch.upgrade.DetectEsInstallationTaskTests
  1> [2022-03-22T02:33:20,997][INFO ][o.o.u.DetectEsInstallationTaskTests] [testRetrieveDefaultUrlFromConfig] before test
  1> [2022-03-22T02:33:21,287][INFO ][o.o.u.DetectEsInstallationTaskTests] [testRetrieveDefaultUrlFromConfig] after test
  1> [2022-03-22T02:33:21,336][INFO ][o.o.u.DetectEsInstallationTaskTests] [testTaskExecution] before test
  1> [2022-03-22T02:33:21,978][INFO ][o.o.u.DetectEsInstallationTaskTests] [testTaskExecution] after test
  2> REPRODUCE WITH: ./gradlew ':distribution:tools:upgrade-cli:test' --tests "org.opensearch.upgrade.DetectEsInstallationTaskTests.testTaskExecution" -Dtests.seed=D13BB0340B7301E1 -Dtests.security.manager=false -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sl -Dtests.timezone=Asia/Kolkata -Druntime.java=11
  2> java.lang.AssertionError: 
    Expected: a collection with size <0>
         but: collection size was <5>
        at __randomizedtesting.SeedInfo.seed([D13BB0340B7301E1:9B2194BFDF244E64]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.upgrade.DetectEsInstallationTaskTests.testTaskExecution(DetectEsInstallationTaskTests.java:53)
  1> [2022-03-22T02:33:21,994][INFO ][o.o.u.DetectEsInstallationTaskTests] [testRetrieveUrlFromSettings] before test
  1> [2022-03-22T02:33:21,996][INFO ][o.o.u.DetectEsInstallationTaskTests] [testRetrieveUrlFromSettings] after test
  2> NOTE: leaving temporary files on disk at: /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/distribution/tools/upgrade-cli/build/testrun/test/temp/org.opensearch.upgrade.DetectEsInstallationTaskTests_D13BB0340B7301E1-001
  2> NOTE: test params are: codec=Asserting(Lucene87): {}, docValues:{}, maxPointsInLeafNode=1578, maxMBSortInHeap=6.043260160779465, sim=Asserting(RandomSimilarity(queryNorm=false): {}), locale=sl, timezone=Asia/Kolkata
  2> NOTE: Linux 5.13.0-1014-aws amd64/Eclipse Adoptium 11.0.14.1 (64-bit)/cpus=72,threads=1,free=416662832,total=536870912
  2> NOTE: All tests run in this JVM: [DetectEsInstallationTaskTests]

Tests with failures:
 - org.opensearch.upgrade.DetectEsInstallationTaskTests.testTaskExecution

#1846

@dblock
Copy link
Member

dblock commented Mar 21, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d5b40e8ab127b5430f1443976d83cc8d11df99e1
Log 3632

Reports 3632

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d0075a4
Log 3639

Reports 3639

@nknize nknize merged commit ff679bf into opensearch-project:1.x Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants