Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore_malformed parameter on ip_range data_type throws mapper_parsing_exception #2429

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Mar 10, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Allows using ignore_malformed on a mapping for ip_range data type

Issues Resolved

Closes #1873

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner March 10, 2022 13:57
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 187405a69b6ebcfe9742966b4352d6e1e39c1143
Log 3224

Reports 3224

@reta
Copy link
Collaborator Author

reta commented Mar 10, 2022

x Gradle Check failure 187405a Log 3224

Reports 3224

Should be fixed by #2430

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 187405a69b6ebcfe9742966b4352d6e1e39c1143
Log 3228

Reports 3228

@tlfeng
Copy link
Collaborator

tlfeng commented Mar 10, 2022

In log 3228:

> Task :qa:full-cluster-restart:v1.3.0#oldClusterTest

REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testEmptyShard" -Dtests.seed=62097E0829CCE721 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=lv -Dtests.timezone=Europe/Chisinau -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testEmptyShard FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://[::1]:36423], URI [/test_empty_shard], status line [HTTP/1.1 200 OK]
    Warnings: [Translog retention settings [index.translog.retention.age] and [index.translog.retention.size] are deprecated and effectively ignored. They will be removed in a future version.]
    {"acknowledged":true,"shards_acknowledged":true,"index":"test_empty_shard"}
        at __randomizedtesting.SeedInfo.seed([62097E0829CCE721:2E72A9D0D5F5C8B4]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:973)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testEmptyShard(FullClusterRestartIT.java:670)

It's reported in #2359.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d9372890b8e4c4200c967f00411c6ccf7a12f9d5
Log 3229

Reports 3229

@tlfeng
Copy link
Collaborator

tlfeng commented Mar 10, 2022

start gradle check

@tlfeng
Copy link
Collaborator

tlfeng commented Mar 10, 2022

🙂 Log 3229 shows the same failure:

> Task :qa:full-cluster-restart:v1.4.0#oldClusterTest

REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.4.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testEmptyShard" -Dtests.seed=14328B4A03131133 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ro-RO -Dtests.timezone=America/Fortaleza -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testEmptyShard FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://[::1]:38935], URI [/test_empty_shard], status line [HTTP/1.1 200 OK]
    Warnings: [Translog retention settings [index.translog.retention.age] and [index.translog.retention.size] are deprecated and effectively ignored. They will be removed in a future version.]
    {"acknowledged":true,"shards_acknowledged":true,"index":"test_empty_shard"}
        at __randomizedtesting.SeedInfo.seed([14328B4A03131133:58495C92FF2A3EA6]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:973)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testEmptyShard(FullClusterRestartIT.java:670)

@reta
Copy link
Collaborator Author

reta commented Mar 10, 2022

One of my recent pull requests succeed on 5th attempt only :(

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d9372890b8e4c4200c967f00411c6ccf7a12f9d5
Log 3230

Reports 3230

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 6244a586d7ae7fd81fd366d57797029a3f2432c1
Log 3232

Reports 3232

@dblock dblock requested review from andrross and tlfeng March 10, 2022 21:56
@nknize nknize added v2.0.0 Version 2.0.0 bug Something isn't working Indexing & Search labels Mar 21, 2022
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like we need a rebase since this sat open for so long. 🤦‍♂️

…g_exception

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 24eac75
Log 3602

Reports 3602

@dblock dblock merged commit 1a3dbb7 into opensearch-project:main Mar 21, 2022
reta added a commit to reta/OpenSearch that referenced this pull request Mar 22, 2022
…g_exception (opensearch-project#2429)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dblock pushed a commit that referenced this pull request Mar 22, 2022
…g_exception (#2429) (#2542)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Indexing & Search v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ignore_malformed parameter on ip_range data_type throws mapper_parsing_exception
6 participants