Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Version] Increment 1.x to 1.4 #2423

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Mar 10, 2022

Signed-off-by: Suraj Singh surajrider@gmail.com

Description

Preparing version bump of 1.x version to 1.4. This can be merged since 1.3 branch is already cut from 1.x.

Issues Resolved

#2257

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89 dreamer-89 requested review from mch2 and adnapibar March 10, 2022 00:25
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f25236954fa4fe4d2563d4dbeb0986ad916107c4
Log 3211

Reports 3211

tlfeng
tlfeng previously approved these changes Mar 10, 2022
@mch2
Copy link
Member

mch2 commented Mar 10, 2022

LGTM - I think we need to also add 1.4 to main's bwcVersions https://github.com/opensearch-project/OpenSearch/blob/main/.ci/bwcVersions

@tlfeng tlfeng dismissed their stale review March 10, 2022 00:33

There is a test failure related to the version.

@dreamer-89 dreamer-89 removed the request for review from adnapibar March 10, 2022 00:36
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d83d631688251e045a6a606e09ac0e22321c1ef6
Log 3213

Reports 3213

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success cf1c44feab554fee81c602d2727aa2233a0cde28
Log 3214

Reports 3214

@dreamer-89 dreamer-89 removed the request for review from tlfeng March 10, 2022 01:36
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 294ed3a
Log 3216

Reports 3216

@dreamer-89 dreamer-89 merged commit a61080d into opensearch-project:1.x Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants