Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.x] Deprecate setting 'reindex.remote.whitelist' and introduce the alternative setting 'reindex.remote.allowlist' #2406

Closed
wants to merge 1 commit into from
Closed

[Backport 1.x] Deprecate setting 'reindex.remote.whitelist' and introduce the alternative setting 'reindex.remote.allowlist' #2406

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 63c75d1 from #2221

@github-actions
Deprecate setting 'reindex.remote.whitelist' and introduce the altern…
4eda283 
…ative setting 'reindex.remote.allowlist' (#2221)

* Add setting reindex.remote.allowlist, and deprecate setting reindex.remote.whitelist

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Add unit test for renaming the setting reindex.remote.allowlist

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Remove system.out.println()

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Adjust format by spotlessApply task

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Replace REMOTE_CLUSTER_WHITELIST with REMOTE_CLUSTER_ALLOWLIST

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Add a unit test to test final setting value when both settings have got a value

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Rename the unit test class name

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Remove the Access modifiers public from the constant REMOTE_CLUSTER_WHITELIST

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Initialize ReindexPlugin without using the @before method

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Rename 'unwhitelisted' to 'unallowlisted' in a yml file used for REST api testing.

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit 63c75d1)
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4eda283
Log 3167

Reports 3167

@tlfeng
Copy link
Collaborator

tlfeng commented Mar 8, 2022 •
edited
Loading

In Log 3167:

> Task :distribution:tools:upgrade-cli:test


org.opensearch.upgrade.DetectEsInstallationTaskTests > testTaskExecution FAILED
    java.lang.AssertionError: 
    Expected: a collection with size <0>
         but: collection size was <5>
        at __randomizedtesting.SeedInfo.seed([90E1C75E01AA5E94:DAFBE3D5D5FD1111]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.upgrade.DetectEsInstallationTaskTests.testTaskExecution(DetectEsInstallationTaskTests.java:53)
REPRODUCE WITH: ./gradlew ':distribution:tools:upgrade-cli:test' --tests "org.opensearch.upgrade.DetectEsInstallationTaskTests.testTaskExecution" -Dtests.seed=90E1C75E01AA5E94 -Dtests.security.manager=false -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-BO -Dtests.timezone=Zulu -Druntime.java=11

It is reported in issue #1846, can't be reproduced locally.

@tlfeng
Copy link
Collaborator

tlfeng commented Mar 8, 2022

start gradle check

@tlfeng tlfeng added backport PRs or issues specific to backporting features or enhancments enhancement Enhancement or improvement to existing feature or request v1.3.0 labels Mar 8, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 4eda283
Log 3172

Reports 3172

@tlfeng tlfeng added blocked Identifies issues that are blocked and removed v1.3.0 labels Mar 8, 2022
@tlfeng
Copy link
Collaborator

tlfeng commented Mar 15, 2022

Close the PR, because the setting name change is not going to backport to 1.x version. Described here: #2221 (comment)

@tlfeng tlfeng closed this Mar 15, 2022
@peterzhuamazon peterzhuamazon deleted the backport/backport-2221-to-1.x branch July 8, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments blocked Identifies issues that are blocked enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opensearch-ci-bot @tlfeng