[Remove] Type from Search Internals #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknize
added
v2.0.0
|
Can one of the admins verify this patch? |
nknize
added
the
non-issue
|
❌ Gradle Check failure c58c6710a963b1af64d7db3cc86d2074e4a2543d |
|
❌ Gradle Check failure fc4bcc02fb282395b4dc431201a5f6f554ea2c78 |
nknize
force-pushed
the
remove/typeFromSearchInternals
branch
from
fc4bcc0
to
46ea66b
Compare
|
✅ Gradle Check success 46ea66b94d2ff088d667818ef0ac7ce83b12fa34 |
reta
reviewed
Feb 17, 2022
| @@ -153,18 +153,6 @@ public static IdsQueryBuilder idsQuery() { | |||
| return new IdsQueryBuilder(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The public static TypeQueryBuilder typeQuery(String type) should also be gone, right?
There was a problem hiding this comment.
yes! not used anywhere. Removed
With types deprecation the type support is removed from internal search API (SearchRequest and QueryShardContext). Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
force-pushed
the
remove/typeFromSearchInternals
branch
from
46ea66b
to
680c8b5
Compare
reta
approved these changes
Feb 17, 2022
CEHENKLE
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With types deprecation the type support is removed from internal search API
(
SearchRequestandQueryShardContext).relates #1940