[Backport 1.x] Add regexp interval source #2069
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Add regexp interval source Add a regexp interval source provider so people can use regular expressions inside of intervals queries. Signed-off-by: Matt Weber <matt@mattweber.org> * Fixes - register regexp interval in SearchModule - use fully-qualified name for lucene RegExp - get rid of unnecessary variable Signed-off-by: Matt Weber <matt@mattweber.org> (cherry picked from commit b9420d8)
|
Can one of the admins verify this patch? |
|
@mattweber are you saying this will need serialization checks on top of? bcw tests? |
|
@dblock yes this needs a few or the bwc tests will fail. With this merged, I can do PR for the proper checks. |
| } | ||
|
|
||
| public Regexp(StreamInput in) throws IOException { | ||
| this.pattern = in.readString(); |
There was a problem hiding this comment.
Need version checks >= 1.3
There was a problem hiding this comment.
@mattweber do you think you need it? the 1.3.0+ would recognize case "regexp" but older clusters would not, so we should not see the case when older cluster tries to reconstruct Regexp from the stream
There was a problem hiding this comment.
Yea I am not sure, usually I do the checks for an existing feature not a new one. Maybe we just go as is and see if we start triggering any BWC failures. In which case I can do a followup PR for version checks.
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.writeString(pattern); |
|
Will also need to add the same checks to |
|
@reta can you please look at this? Now that I think of it I am not sure what the correct way to handle this is since it is a completely new feature and with a version check the entire |
|
@dblock I think we can merge this without any checks (see above comments). If any bwc checks start to fail I will open a follow-up PR to address it. Thank you! |
|
@dblock is this ok to be merged or would you like me to make some changes? |
|
start gradle check |
|
@mattweber For gradle check failures, check the log please, open/update existing issues for any new/known failures and I or any other admin can kick it again. |
|
start gradle check |
|
start gradle check |
|
... http://vault.centos.org/centos/ is having issues |
|
start gradle check |
|
start gradle check |
|
@dblock can you merge please? |
Backport b9420d8 from #1917