Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Shadow plugin to 7.1.2 #2033

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Upgrading Shadow plugin to 7.1.2 #2033

merged 1 commit into from
Feb 2, 2022

Conversation

saratvemulapalli
Copy link
Member

Signed-off-by: Sarat Vemulapalli vemulapallisarat@gmail.com

Description

Upgrading Shadow gradle plugin to 7.1.2.
Shadow plugin is used for publishing jars
and this upgrades Log4J dependency for build.
Ref: https://github.com/johnrengelman/shadow/releases/tag/7.1.2

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Shadow plugin is used for publishing jars
and this upgrades Log4J dependency for build.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@saratvemulapalli saratvemulapalli requested a review from a team as a code owner February 2, 2022 03:00
@saratvemulapalli saratvemulapalli added >upgrade Label used when upgrading library dependencies (e.g., Lucene) CVE Fixes a CVE v1.3.0 labels Feb 2, 2022
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4f14c8b
Log 2165

Reports 2165

@saratvemulapalli
Copy link
Member Author

❌   Gradle Check failure 4f14c8b Log 2165

Reports 2165

Tests with failures:
 - org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation

@saratvemulapalli
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4f14c8b
Log 2166

Reports 2166

@saratvemulapalli
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 4f14c8b
Log 2167

Reports 2167

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nknize nknize merged commit 1f9517c into opensearch-project:main Feb 2, 2022
@saratvemulapalli saratvemulapalli deleted the shadow-plugin-upgrade branch February 2, 2022 16:50
github-actions bot pushed a commit that referenced this pull request Feb 2, 2022
Shadow plugin is used for publishing jars
and this upgrades Log4J dependency for build.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
(cherry picked from commit 1f9517c)
saratvemulapalli added a commit that referenced this pull request Feb 2, 2022
Shadow plugin is used for publishing jars
and this upgrades Log4J dependency for build.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
(cherry picked from commit 1f9517c)

Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
saratvemulapalli added a commit that referenced this pull request Feb 3, 2022
This reverts commit 8725061.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@saratvemulapalli saratvemulapalli added >breaking Identifies a breaking change. and removed v1.3.0 labels Feb 15, 2022
kotwanikunal pushed a commit to kotwanikunal/OpenSearch that referenced this pull request Jun 22, 2023
Shadow plugin is used for publishing jars
and this upgrades Log4J dependency for build.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
(cherry picked from commit 1f9517c)
kotwanikunal pushed a commit to kotwanikunal/OpenSearch that referenced this pull request Jun 22, 2023
Shadow plugin is used for publishing jars
and this upgrades Log4J dependency for build.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
(cherry picked from commit 1f9517c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking Identifies a breaking change. CVE Fixes a CVE >upgrade Label used when upgrading library dependencies (e.g., Lucene) v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants