Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecate] index.merge.policy.max_merge_at_once_explicit #1981

Merged
merged 1 commit into from
Jan 27, 2022
Merged

[Deprecate] index.merge.policy.max_merge_at_once_explicit #1981

merged 1 commit into from
Jan 27, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jan 26, 2022

max_merge_at_once_explicit is removed in lucene 9 so this PR deprecates the corresponding index setting for removal in the next major release.

@nknize
[Deprecate] index.merge.policy.max_merge_at_once_explicit
1b09dff 
max_merge_at_once_explicit is removed in lucene 9 so the index setting is
deprecated for removal in the next major release.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues deprecate labels Jan 26, 2022
@nknize nknize requested a review from a team as a code owner January 26, 2022 22:11
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 1b09dff
Log 2070

Reports 2070

@nknize
Copy link
Collaborator Author

nknize commented Jan 26, 2022

LeUggh.. Yet ANOTHER #1957 failure unrelated to this PR. Documenting and re-firing gradle check

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation" -Dtests.seed=A9609B151E2EF545 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ko -Dtests.timezone=America/Port-au-Prince -Druntime.java=17

org.opensearch.cluster.routing.MovePrimaryFirstTests > testClusterGreenAfterPartialRelocation FAILED
    java.lang.AssertionError: timed out waiting for green state
        at __randomizedtesting.SeedInfo.seed([A9609B151E2EF545:FAAAFF70356A8A51]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:986)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:925)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:914)
        at org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation(MovePrimaryFirstTests.java:67)

@nknize
Copy link
Collaborator Author

nknize commented Jan 26, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 1b09dff
Log 2071

Reports 2071

adnapibar
adnapibar reviewed Jan 27, 2022
View reviewed changes
server/src/main/java/org/opensearch/index/IndexSettings.java
MergePolicyConfig.INDEX_MERGE_POLICY_MAX_MERGE_AT_ONCE_EXPLICIT_SETTING,
mergePolicyConfig::setMaxMergesAtOnceExplicit
);
// todo: remove this in 2.0.0 since it was removed in lucene 9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we going to deprecate this in the next 1.x release and then remove in 2.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'm backporting this PR and open a separate remove PR to main.

adnapibar
adnapibar approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nknize nknize merged commit a18b4e3 into opensearch-project:main Jan 27, 2022
@nknize nknize mentioned this pull request Jan 27, 2022
Merged
nknize added a commit to nknize/OpenSearch that referenced this pull request Jan 27, 2022
@nknize
[Deprecate] index.merge.policy.max_merge_at_once_explicit (opensearch…
bf78928 
…-project#1981)

max_merge_at_once_explicit is removed in lucene 9 so the index setting is
deprecated for removal in the next major release.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added the pending backport Identifies an issue or PR that still needs to be backported label Jan 27, 2022
This was referenced Jan 27, 2022
Merged
Merged
nknize added a commit that referenced this pull request Feb 2, 2022
@nknize
[1x] Deprecate index.merge.policy.max_merge_at_once_explicit (#1981) (#…
d8fb3d8 
…1984)

max_merge_at_once_explicit is removed in lucene 9 so the index setting is
deprecated for removal in the next major release.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@dreamer-89 dreamer-89 mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnapibar adnapibar adnapibar approved these changes

Assignees
No one assigned
Labels
deprecate non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues pending backport Identifies an issue or PR that still needs to be backported v1.3.0 v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nknize @opensearch-ci-bot @adnapibar