[Rename] Refactor ES and Elasticsearch classes in server module bootstrap package #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Request for Admin to accept this test. |
nknize
force-pushed
the
rename/server/bootstrapESClasses
branch
from
614dfa6
to
7e7f274
Compare
|
@opendistro-for-elasticsearch/opensearch-core testing team notification on PR |
adnapibar
reviewed
Mar 8, 2021
server/src/main/java/org/elasticsearch/bootstrap/OpenSearch.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/bootstrap/OpenSearch.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/bootstrap/BootstrapForTesting.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/bootstrap/OpenSearch.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/bootstrap/OpenSearch.java
Outdated
Show resolved
Hide resolved
harold-wang
reviewed
Mar 8, 2021
harold-wang
reviewed
Mar 8, 2021
server/src/test/java/org/elasticsearch/bootstrap/OpenSearchPolicyTests.java
Outdated
Show resolved
Hide resolved
nknize
force-pushed
the
rename/server/bootstrapESClasses
branch
from
0de9b20
to
49b42cc
Compare
This commit refactors The ESPolicy, Elasticsearch, Elasticsearch, We're going to have merge conflicts so revisit! Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Nicholas Knize <nknize@amazon.com>
nknize
force-pushed
the
rename/server/bootstrapESClasses
branch
from
49b42cc
to
68bceee
Compare
Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Nicholas Knize <nknize@amazon.com>
|
looks like several files were recreated instead of moved... I'll take care of that before the next round of review |
Signed-off-by: Nicholas Knize <nknize@amazon.com>
|
Fixed the added files |
tlfeng
approved these changes
Mar 12, 2021
nknize
added a commit
that referenced
this pull request
Mar 22, 2021
…trap package (#197) This commit refactors the heavily used ESPolicy, Elasticsearch (main class), and Elasticsearch prefixed test classes used in the bootstrap package under the server module. Refactoring the namespace will come in a separate commit. Signed-off-by: Nicholas Knize <nknize@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the heavily used ESPolicy, Elasticsearch (main class), and Elasticsearch prefixed test classes used in the bootstrap package under the server module. Refactoring the namespace will come in a separate PR.
relates #160