Skip to content

Conversation

karenyrx
Copy link
Contributor

@karenyrx karenyrx commented Oct 2, 2025

Description

  1. Implement Highlight, sort
  2. Make some methods package private

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@karenyrx karenyrx force-pushed the highlightsort branch 2 times, most recently from 7a10691 to a33ea76 Compare October 2, 2025 00:08
@karenyrx karenyrx changed the title [GRPC] Implement Highlight, sort [GRPC] Implement Highlight, sort search params Oct 2, 2025
@karenyrx karenyrx force-pushed the highlightsort branch 2 times, most recently from 6975088 to b6900c9 Compare October 2, 2025 00:23
Copy link
Contributor

github-actions bot commented Oct 2, 2025

❌ Gradle check result for b6900c9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

package private

remove static registry

tests

Signed-off-by: Karen X <karenxyr@gmail.com>
Copy link
Contributor

github-actions bot commented Oct 2, 2025

✅ Gradle check result for 5864020: SUCCESS

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 90.13605% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.03%. Comparing base (4269bdd) to head (5864020).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...oto/request/search/HighlightBuilderProtoUtils.java 89.56% 5 Missing and 7 partials ⚠️
...roto/request/search/sort/NestedSortProtoUtils.java 75.00% 3 Missing and 2 partials ⚠️
.../request/search/SearchSourceBuilderProtoUtils.java 20.00% 3 Missing and 1 partial ⚠️
...oto/request/search/sort/SortBuilderProtoUtils.java 92.68% 1 Missing and 2 partials ⚠️
...request/search/sort/GeoDistanceSortProtoUtils.java 96.77% 1 Missing and 1 partial ⚠️
...roto/request/search/sort/ScriptSortProtoUtils.java 89.47% 1 Missing and 1 partial ⚠️
...equest/search/sort/FieldSortBuilderProtoUtils.java 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19500      +/-   ##
============================================
+ Coverage     72.97%   73.03%   +0.05%     
- Complexity    70417    70558     +141     
============================================
  Files          5711     5715       +4     
  Lines        322587   322867     +280     
  Branches      46716    46808      +92     
============================================
+ Hits         235402   235800     +398     
+ Misses        68180    68089      -91     
+ Partials      19005    18978      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: karenx <karenx@uber.com>
Copy link
Contributor

github-actions bot commented Oct 2, 2025

❌ Gradle check result for cf74d00: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant