[Rename] plugins #193

harold-wang · 2021-03-04T00:09:12Z

Issue #160 , if available:

Description of changes:

This PR refactors files under "plugins" folder s part of the Elasticsearch to OpenSearch renaming effort.

Signed-off-by: Harold Wang harowang@amazon.com

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

… plugin folder, elasticsearch package name is also refactored. Signed-off-by: Harold Wang <harowang@amazon.com>

odfe-release-bot · 2021-03-04T02:45:05Z

Request for Admin to accept this test.

adnapibar

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

harold-wang · 2021-03-04T18:06:47Z

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

Done, thx.

adnapibar · 2021-03-04T18:23:32Z

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

I will put all git rename in another PR, thx.

I would say the renaming is done as part of the same PR - I don't see the point doing it separately.

Agree, it was done in same PR. thanks

harold-wang · 2021-03-04T20:33:21Z

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

I will put the filename and directory rename in another PR, thanks
I take this suggestion, done it in the same PR.

harold-wang · 2021-03-04T20:58:38Z

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

I will put all git rename in another PR, thx.

I would say the renaming is done as part of the same PR - I don't see the point doing it separately.

OK, I take this suggestions, thanks.

Signed-off-by: Harold Wang <harowang@amazon.com>

Rename ESSingleNodeTestCase to OpenSearchSingleNodeTestCase Signed-off-by: Harold Wang <harowang@amazon.com>

Signed-off-by: Harold Wang <harowang@amazon.com>

Rename elasticsearch@BUILD.ELASTICO.CO" to "opensearch@BUILD.OPENSEARCH.CO" Signed-off-by: Harold Wang <harowang@amazon.com>

Signed-off-by: Harold Wang <harowang@amazon.com>

Rename elasticsearch to opensearch Signed-off-by: Harold Wang <harowang@amazon.com>

Signed-off-by: Harold Wang <harowang@amazon.com>

Rename elasticsearch to opensearch Signed-off-by: Harold Wang <harowang@amazon.com>

harold-wang · 2021-03-05T03:18:07Z

@adnapibar @nknize @abbashus could you please help me review this one? thanks

harold-wang · 2021-03-08T06:17:56Z

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.
Done

harold-wang · 2021-03-08T21:01:23Z

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

I will put all git rename in another PR, thx.

Done, thanks

…search/search into rename_plugin

Signed-off-by: Harold Wang <harowang@amazon.com>

…search/search into rename_plugin Signed-off-by: Harold Wang <harowang@amazon.com>

plugins/analysis-icu/src/test/java/org/opensearch/index/analysis/IcuTokenizerFactoryTests.java

plugins/examples/rest-handler/src/yamlRestTest/resources/rest-api-spec/api/cat.example.json

tlfeng · 2021-03-10T22:31:21Z

...iscovery/gce/compute/v1/projects/nodeswithsametagsandnotagset/zones/europe-west1-b/instances

+      "zone": "europe-west1-b"
+    }
+  ]
+}


Just notice these 3 files with name instances are not identified as renaming, please verify that git can find the files' history.

Do not worry, these file is not part of version controlled file.
git mv elasticsearch opensearch
fatal: source directory is empty, source=plugins/discovery-gce/out/test/resources/org/elasticsearch, destination=plugins/discovery-gce/out/test/resources/org/opensearch

I see. Thanks for telling me! 😄

plugins/transport-nio/src/internalClusterTest/java/org/opensearch/NioIntegTestCase.java

...y-hdfs/src/test/resources/rest-api-spec/test/secure_hdfs_repository/20_repository_create.yml

...gcs/src/test/java/org/opensearch/repositories/gcs/GoogleCloudStorageClientSettingsTests.java

...sitory-gcs/src/test/java/org/opensearch/repositories/gcs/GoogleCloudStorageServiceTests.java

plugins/repository-s3/src/main/plugin-metadata/plugin-security.policy

Signed-off-by: Harold Wang <harowang@amazon.com>

tlfeng

Thank you! All my comments above has been resolved.

* [Rename] plugins (#193) This PR refactors files under "plugins" folders part of the Elasticsearch to OpenSearch renaming effort. Signed-off-by: Harold Wang <harowang@amazon.com>

Signed-off-by: dblock <dblock@amazon.com>

[Rename] Refactor ElasticSearch* class and elasticsearch* instance in…

9ffccc8

… plugin folder, elasticsearch package name is also refactored. Signed-off-by: Harold Wang <harowang@amazon.com>

harold-wang changed the base branch from main to rename/opensearch March 4, 2021 00:15

harold-wang requested review from abbashus, nknize and adnapibar March 4, 2021 00:17

harold-wang changed the title ~~[Rename] Refector plugins folder~~ [Rename] Rename plugins folder Mar 4, 2021

harold-wang self-assigned this Mar 4, 2021

harold-wang added Rename Renaming to OpenSearch >FORK Related to the fork process labels Mar 4, 2021

harold-wang changed the title ~~[Rename] Rename plugins folder~~ [Rename] Rename files under plugins folder Mar 4, 2021

adnapibar suggested changes Mar 4, 2021

View reviewed changes

Merge branch 'rename/opensearch' into rename_plugin

7cd3a31

harold-wang requested a review from adnapibar March 4, 2021 18:30

harold-wang added 11 commits March 4, 2021 13:36

Rename directory from elasticsearch to opensearch

7216f7e

Signed-off-by: Harold Wang <harowang@amazon.com>

Rename directory from elasticsearch to opensearch

4a8b670

Signed-off-by: Harold Wang <harowang@amazon.com>

Rename ESTestCase to OpenSearchTestCase

5e84bcd

Rename ESSingleNodeTestCase to OpenSearchSingleNodeTestCase Signed-off-by: Harold Wang <harowang@amazon.com>

Rename org.elasticsearch to org.opensearch in *.gradle

1239ac7

Signed-off-by: Harold Wang <harowang@amazon.com>

Rename elasticsearch to opensearch in *.gradle

ecd89d3

Signed-off-by: Harold Wang <harowang@amazon.com>

Rename elasticsearch to opensearch

ca4c1fc

Rename elasticsearch@BUILD.ELASTICO.CO" to "opensearch@BUILD.OPENSEARCH.CO" Signed-off-by: Harold Wang <harowang@amazon.com>

Rename "user/elasticsearch" to "user/opensearch"

249e5d4

Signed-off-by: Harold Wang <harowang@amazon.com>

Rename esplugin to opensearchplugin

40a6b17

Rename elasticsearch to opensearch Signed-off-by: Harold Wang <harowang@amazon.com>

Rename elasticsearch to opensearch in gradle description

e31ce10

Signed-off-by: Harold Wang <harowang@amazon.com>

Rename Elasticsearch to Opensearch in description message

03fb93d

Signed-off-by: Harold Wang <harowang@amazon.com>

Rename Elasticsearch to Opensearch

f79951c

Rename elasticsearch to opensearch Signed-off-by: Harold Wang <harowang@amazon.com>

harold-wang mentioned this pull request Mar 8, 2021

Fork rename to opensearch #171

Closed

harold-wang added 2 commits March 10, 2021 09:49

Merge branch 'rename/opensearch' of github.com:opendistro-for-elastic…

5e65662

…search/search into rename_plugin

Rename ES|es to OpenSearch|opensearch

d8b63b3

Signed-off-by: Harold Wang <harowang@amazon.com>

harold-wang requested a review from saratvemulapalli March 10, 2021 21:55

Merge branch 'rename/opensearch' of github.com:opendistro-for-elastic…

8c52dfc

…search/search into rename_plugin Signed-off-by: Harold Wang <harowang@amazon.com>

tlfeng reviewed Mar 10, 2021

View reviewed changes

Fix a renaming error: reverting org/opensearch/search

93cd26f

Signed-off-by: Harold Wang <harowang@amazon.com>

tlfeng approved these changes Mar 11, 2021

View reviewed changes

harold-wang changed the title ~~[Rename] Rename files under plugins folder~~ [Rename] plugins Mar 11, 2021

harold-wang merged commit f27f5ac into opensearch-project:rename/opensearch Mar 11, 2021

jamesiri unassigned harold-wang Mar 15, 2021

nknize pushed a commit that referenced this pull request Mar 22, 2021

[Rename] plugins (#193)

82f9ff9

* [Rename] plugins (#193) This PR refactors files under "plugins" folders part of the Elasticsearch to OpenSearch renaming effort. Signed-off-by: Harold Wang <harowang@amazon.com>

nknize mentioned this pull request Mar 22, 2021

[Rename] Rename from org.elasticsearch to org.opensearch #160

Closed

ritty27 pushed a commit to ritty27/OpenSearch that referenced this pull request May 12, 2024

Extract version into gradle.properties. (opensearch-project#193)

2c30d4e

Signed-off-by: dblock <dblock@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Rename] plugins #193

[Rename] plugins #193

harold-wang commented Mar 4, 2021 •

edited

Loading

odfe-release-bot commented Mar 4, 2021

adnapibar left a comment

harold-wang commented Mar 4, 2021 •

edited

Loading

adnapibar commented Mar 4, 2021 •

edited by harold-wang

Loading

harold-wang commented Mar 4, 2021 •

edited

Loading

harold-wang commented Mar 4, 2021

harold-wang commented Mar 5, 2021

harold-wang commented Mar 8, 2021

harold-wang commented Mar 8, 2021

tlfeng Mar 10, 2021

harold-wang Mar 11, 2021

tlfeng Mar 11, 2021

tlfeng left a comment

[Rename] plugins #193

[Rename] plugins #193

Conversation

harold-wang commented Mar 4, 2021 • edited Loading

odfe-release-bot commented Mar 4, 2021

adnapibar left a comment

Choose a reason for hiding this comment

harold-wang commented Mar 4, 2021 • edited Loading

adnapibar commented Mar 4, 2021 • edited by harold-wang Loading

harold-wang commented Mar 4, 2021 • edited Loading

harold-wang commented Mar 4, 2021

harold-wang commented Mar 5, 2021

harold-wang commented Mar 8, 2021

harold-wang commented Mar 8, 2021

tlfeng Mar 10, 2021

Choose a reason for hiding this comment

harold-wang Mar 11, 2021

Choose a reason for hiding this comment

tlfeng Mar 11, 2021

Choose a reason for hiding this comment

tlfeng left a comment

Choose a reason for hiding this comment

harold-wang commented Mar 4, 2021 •

edited

Loading

harold-wang commented Mar 4, 2021 •

edited

Loading

adnapibar commented Mar 4, 2021 •

edited by harold-wang

Loading

harold-wang commented Mar 4, 2021 •

edited

Loading