Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [1.x] Modernize and consolidate JDKs usage across all stages of the build. Use JDK-17 as bundled JDK distribution to run tests #1922

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Jan 17, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Backport of #1358 and #1368 to 1.x

Issues Resolved

Closes #1910

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…Use JDK-17 as bundled JDK distribution to run tests

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@reta
Copy link
Collaborator Author

reta commented Jan 17, 2022

@dblock interestingly, we updated the DEVELOPER_GUIDE.md with JDK-17 notes (from main) already :-) so things should be right in order now

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 85df50d
Log 1957

Reports 1957

Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like @dblock to also take a look at this.

@dblock dblock merged commit c0332f3 into opensearch-project:1.x Jan 18, 2022
@dblock
Copy link
Member

dblock commented Jan 18, 2022

Good work, thanks!

@dblock
Copy link
Member

dblock commented Jan 18, 2022

I think we need to talk about this whole JDK version business, I opened opensearch-project/project-website#628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants